Fix wrong realm used when executing mojos #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this fixes the previous failures and did not show any ne ones I think this is good to be merged. |
Sorry I didn't have the time yet to review/undestand this in detail. But yes since all tests pass it is probably not too bad.
Can you explain where this is cached? In M2E or Maven itself? Since this is a non obvious behavior, I think it would be good to have some comments in the code explaining why execution is cloned?! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MojoSetup is cached what do not seem working fine with different containers. This now changes the way to fetch a fresh configuration that takes the current context into account.
Based on
This fixes