[Build] Replace deprecated GabrielBB/xvfb-action by coactions/setup-xvfb

[HannesWell]

No description provided.

[github-actions]

Test Results

   198 files  ±0     198 suites  ±0   24m 55s ⏱️ - 4m 24s
   620 tests ±0     613 ✔️ +1    7 💤 ±0  0 ❌  - 1 
1 240 runs  ±0  1 226 ✔️ +1  14 💤 ±0  0 ❌  - 1 

Results for commit 0894eed. ± Comparison against base commit f5e9cdc.

♻️ This comment has been updated with latest results.

[mickaelistria]

FWIW, I recently managed to get rid of Xvfb in CI with https://github.com/redhat-developer/eclipseide-jdtls/blob/main/.github/workflows/validate.yml#L22..L28 . It can be worth preferring mutter over wayland to Xvfb as Xvfb isn't much maintained any longer and all main Linux distro use mutter and dropped X by default.

[HannesWell]

That's interesting. Do you know if there is then an equivalent GH-action like setup-xvfb and a Jenkins Plugin like xvfb?

[mickaelistria]

Back then, I searched and found no GitHub actions; but 4 lines of bash for mutter is IMO more interesting than 1 line of GH action for Xvfb.

[laeubi]

Back then, I searched and found no GitHub actions; but 4 lines of bash for mutter is IMO more interesting than 1 line of GH action for Xvfb.

I don't think so, please take into account that the action do much more than "just starting xvfb", e.g. it detects if you run on windows and turn it there into a noop. So if you think mutter is superior it might be good to report it to the people of that action so they can consider using mutter as an alternative.

[mickaelistria]

much more than "just starting xvfb", e.g. it detects if you run on windows and turn it there into a noop

That's not really much more, adding a if: ${{ runner.os == 'Linux' }} should do te trick.

So if you think mutter is superior

It's not just me, it's the consensus for all mainstream recent linux distributions who've stopped using X by default.

it might be good to report it to the people of that action so they can consider using mutter as an alternative.

I don't really care about the action, I'm pretty happy with the steps described above which give more control.

[laeubi]

That's not really much more, adding a if: ${{ runner.os == 'Linux' }} should do te trick.

If the trick is to not execute anything at all on other OS (what about mac?) ... also this currently never do any cleanups.

I don't really care about the action, I'm pretty happy with the steps described above which give more control.

Sure if you just need to manage/control exactly one (or maybe two or three) repositories / actions it might be fine, for all other cases it just don't scale very well.

[HannesWell]

Back then, I searched and found no GitHub actions; but 4 lines of bash for mutter is IMO more interesting than 1 line of GH action for Xvfb.

I don't think so, please take into account that the action do much more than "just starting xvfb", e.g. it detects if you run on windows and turn it there into a noop. So if you think mutter is superior it might be good to report it to the people of that action so they can consider using mutter as an alternative.

Created an issue: coactions/setup-xvfb#16
Please share your opinion there as I cannot really say much about the topic.