Keep external annotations paths when updating the project configuration (fixes #391) #1635
Conversation
sebthom
force-pushed
the
external-anno
branch
2 times, most recently
from
c1f8483
to
ba7b66c
Compare
|
@sebthom can you squash your commits and add a commit message that described the current and improved state? |
sebthom
force-pushed
the
external-anno
branch
from
ba7b66c
to
1db97cd
Compare
|
@laeubi done |
sebthom
force-pushed
the
external-anno
branch
from
1db97cd
to
e2f951b
Compare
|
@HannesWell @laeubi I would greatly appreciate it if this could be included in the next m2e release. 🤞 |
sebthom
force-pushed
the
external-anno
branch
from
e2f951b
to
0464b1a
Compare
HannesWell
force-pushed
the
external-anno
branch
from
0464b1a
to
76776ba
Compare
Prior to this commit, the manually configured external annotation paths for the "JRE System Library" and "Maven Dependencies" classpath entries of an m2e managed Eclipse project were being unset when m2e updated the Eclipse project configuration, e.g. due to changes in the underlying Maven project or due to manual execution of "Maven -> Update project...". This commit ensures that the external annotation path settings are still present after m2e updated the Eclipse project configuration. Fixes eclipse-m2e#391
HannesWell
force-pushed
the
external-anno
branch
from
76776ba
to
9c9704d
Compare
There was a problem hiding this comment.
@sebthom thank you for this contribution, it looks good.
I just reworked it a bit to reduce code-duplication and to stream-line the creation of new classpath-entries, but the behavior should be the same (as your tests shows).
Btw. if you are concerned about changes in the configuration due to automated updates, the PR #1664 might be interesting for you.
HannesWell
changed the title
|
@HannesWell Looks good to me. Thanks for reviewing/updating! |
Great. Thanks for the fast feedback. |
Prior to this commit, the manually configured external annotation paths for the "JRE System Library" and "Maven Dependencies" classpath entries of an m2e managed Eclipse project were being unset when m2e updated the Eclipse project configuration, e.g. due to changes in the underlying Maven project or due to manual execution of "Maven -> Update project...".
This commit ensures that the external annotation path settings are still present after m2e updated the Eclipse project configuration.
Fixes #391