Properly create IJavaProject in JpmsConfigurationTest #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern used to cast java nature to java project is wrong and we have seen it used in many places but broke for some reason with 2024-03. This reduces the failing tests of eclipse-m2e#1720 .
Test Results 214 files ±0 214 suites ±0 23m 10s ⏱️ - 6m 22s For more details on these failures, see this check. Results for commit 439ddfb. ± Comparison against base commit 41bce90. |
|
Unrelated test failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern used to cast java nature to java project is wrong and we have seen it used in many places but broke for some reason with 2024-03. This reduces the failing tests of
#1720 .