Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate keyboard shortcut for Marketplace 'Find' input box and Installed tab #1

Closed
jonahgraham opened this issue Sep 25, 2023 · 1 comment

Comments

@jonahgraham
Copy link

Originally created in eclipse-packaging/packages#64

The keyboard shortcut shown on the Eclipse Marketplace Search tab is the 'i' of 'Find'. However, when using that shortcut in Marketplace, the tab is changed to the 'Installed' tab.

Steps performed:

  1. Open Eclipse
  2. Select Help->Eclipse Marketplace...
  3. Click outside or move the focus out of the Search tab's 'Find' input box
  4. Use the keyboard shortkey, ALT+i

Expected behavior:

  • Focus moved to the Search tab's 'Find' input box

Actual behavior:

  • The Installed tab is shown

Suggested fixes:

  • Change the keyboard shortcut to place the focus into the 'Find' input box (e.g., 'ALT+f', 'ALT+n', or 'ALT+d')
  • Remove the keyboard shortcut to change to the Installed tab
@jonahgraham
Copy link
Author

It seems these two accelerators are provided by different projects, the Installed seems to come from:

But the Find comes from:

https://github.com/eclipse-equinox/p2/blob/fe258ce779cb3d13401f3ac71c0524e8ffbbf28d/bundles/org.eclipse.equinox.p2.ui.discovery/src/org/eclipse/equinox/internal/p2/ui/discovery/wizards/messages.properties#L18

For MPC changing the accelerator for Installed is probably easiest.

l3-g5 added a commit that referenced this issue Feb 28, 2024
Change-Id: I0000000000000000000000000000000000000000
Signed-off-by: Leif Geiger <leif.geiger@yatta.de>
@l3-g5 l3-g5 closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants