Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing org.antlr.runtime package #65

Closed
gnl42 opened this issue Mar 17, 2023 · 16 comments
Closed

Missing org.antlr.runtime package #65

gnl42 opened this issue Mar 17, 2023 · 16 comments

Comments

@gnl42
Copy link
Contributor

gnl42 commented Mar 17, 2023

I see this when I launch Mylyn:

!ENTRY org.eclipse.mylyn.reviews.tasks.dsl 4 0 2023-03-16 22:53:12.415 !MESSAGE FrameworkEvent ERROR !STACK 0 org.osgi.framework.BundleException: Could not resolve module: org.eclipse.mylyn.reviews.tasks.dsl [448] Unresolved requirement: Import-Package: org.antlr.runtime; version="[3.0.0,3.1.0)"

@ruspl-afed
Copy link
Contributor

org.eclipse.mylyn.reviews.tasks.dsl is not a part of build process, the whole https://github.com/eclipse-mylyn/org.eclipse.mylyn/tree/main/mylyn.reviews/tbr folder is not a part of the build.
If you think it should be - please reformulate the issue.

@gnl42
Copy link
Contributor Author

gnl42 commented Mar 17, 2023 via email

@BeckerFrank
Copy link
Contributor

BeckerFrank commented Mar 17, 2023

Did you use the launch config stored here (/org.eclipse.mylyn.development/Work)?
This works for me!

@BeckerFrank
Copy link
Contributor

I think that the tbr (task based reviews) are not active and we can delete the whole folder.
Can not reproduce the launch error.

@gnl42
Copy link
Contributor Author

gnl42 commented Mar 19, 2023 via email

@BeckerFrank
Copy link
Contributor

OK,
now I know why I can not reproduce this.

I use the Mylyn Setup from the Eclipse-Installer and here we do not import all the projects.
We exclude the following path

  • mylyn.builds/org.eclipse.mylyn.hudson.tests/testdata
  • mylyn.reviews/tbr
  • mylyn.docs
  • /org.eclipse.mylyn.java.tests/target

so you need to close or remove the projects located in the excluded path.

Maybe you can use the Eclipse-Installer Mylyn setup the next time you install a new IDE.

@gnl42
Copy link
Contributor Author

gnl42 commented Mar 19, 2023 via email

@BeckerFrank
Copy link
Contributor

@gnl42
Copy link
Contributor Author

gnl42 commented Mar 21, 2023

Have it working now

@gnl42
Copy link
Contributor Author

gnl42 commented Mar 21, 2023

So how do I make my development eclipse match what the .setup file does since I'm working with my forked repository?

@wimjongman
Copy link
Member

Just setup the dev environment and then in the Git perspective, add your remote to the repo.

@ruspl-afed
Copy link
Contributor

Is it still relevant @gnl42 ?

@gnl42
Copy link
Contributor Author

gnl42 commented Apr 15, 2023

HI @ruspl-afed, not really.

I guess the question is why is the
`We exclude the following path

mylyn.builds/org.eclipse.mylyn.hudson.tests/testdata
mylyn.reviews/tbr
mylyn.docs
/org.eclipse.mylyn.java.tests/target

`
part of the repository if they are not part of the build?

@gnl42 gnl42 closed this as completed Apr 15, 2023
@BeckerFrank
Copy link
Contributor

HI @ruspl-afed, not really.

I guess the question is why is the `We exclude the following path

mylyn.builds/org.eclipse.mylyn.hudson.tests/testdata
mylyn.reviews/tbr
mylyn.docs
/org.eclipse.mylyn.java.tests/target

` part of the repository if they are not part of the build?

The exclude is only for the "Projects Import" so .project files in that part of the repository are ignored.

  • mylyn.builds/org.eclipse.mylyn.hudson.tests/testdata
    If you import you get 65 errors in the Error View
  • mylyn.reviews/tbr
    Task-based checks (tbr) were not really active, if I remember correctly (similar to the Bugzilla REST Connector)
  • mylyn.docs
    we can remove this because this is now an other repository
  • /org.eclipse.mylyn.java.tests/target
    only relevant if you did a maven build an the import the projects

@gnl42
Copy link
Contributor Author

gnl42 commented Apr 16, 2023 via email

@BeckerFrank
Copy link
Contributor

Let me rephrase that. Why are these "projects" around if it requires special knowledge to import the repository in order to have a clean workspace? What's the purpose of the projects? George

  • mylyn.builds/org.eclipse.mylyn.hudson.tests/testdata
    the testdata is used for the setup of the Jenkins Test Instance (jobs/test-ant/config.xml)
  • mylyn.reviews/tbr
    this is no longer active but I do not want to delete it yet so I first only do not do a Project Import for the projects
  • mylyn.docs
    this is the previous location of https://github.com/eclipse-mylyn/org.eclipse.mylyn.docs/ and we can remove this now
  • /org.eclipse.mylyn.java.tests/target
    I found a few other cases where a Maven build left .project files in the build (target) folder and a Project Import added those projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants