Remove guava in wikitext, Part 1 #521 #530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I merge this now, or should I wait for 4.3.0 to be released? |
I think it depends on how we handle #354 (also planned for 4.3). |
|
Too risky for 4.3.0, we have not more than 3 days to produce final bits |
|
Do you think we can remove unrelated changes from this PR @gnl42 ? There are a lot of changed line ends. |
|
Sigh, what are they doing back. I cleaned up all that. Use 'Hide whitespace' |
|
Wrecken fracken. Just realized what I did. I'll redo the merge |
gnl42
force-pushed
the
521-remove-guava-in-wikitext
branch
from
84e1fa4
to
1ce5b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace basic guava constructs with Java 17/Apache commons equivalents