Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove guava in wikitext, part 1 #521 #565

Merged
merged 3 commits into from
Jun 30, 2024
Merged

remove guava in wikitext, part 1 #521 #565

merged 3 commits into from
Jun 30, 2024

Conversation

gnl42
Copy link
Contributor

@gnl42 gnl42 commented Jun 30, 2024

Recreation of #530.

Replace guava constructs with native/apache commons equivalents.

Still have:

  • CharMatcher
  • Escaper
  • Splitter

with no simple alternatives (that I've found)

@gnl42 gnl42 mentioned this pull request Jun 30, 2024
Closed
ruspl-afed
ruspl-afed approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot @gnl42 for reviving this work!

@ruspl-afed ruspl-afed merged commit 8afd29e into main Jun 30, 2024
4 checks passed
@ruspl-afed ruspl-afed deleted the 521-Remove-guava-in-wikitext,-part-1 branch June 30, 2024 11:27
@stephan-herrmann stephan-herrmann mentioned this pull request Jul 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruspl-afed ruspl-afed ruspl-afed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnl42 @ruspl-afed