(0.35) Avoid size overflow when allocating memory #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard against very large allocation sizes which overflow when memory tagging overhead is added. Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
Restore allocation headers in the case realloc fails Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
pshipton
requested review from
charliegracie,
mstoodle and
0xdaryl
as code owners
dnakamura
approved these changes
Oct 19, 2022
babsingh
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick the commits from eclipse/omr#6771 for 0.35
Commit 1 - Guard against very large allocation sizes which overflow
when memory tagging overhead is added.
Commit 2 - omrmemtest: check that large allocations don't overflow.
Commit 3 - Handle reallocation failures: Restore allocation headers in
the case realloc fails.