Skip to content

Commit

Permalink
Merge pull request #4227 from DanHeidinga/djh/sccdisable
Browse files Browse the repository at this point in the history
Disable SCC by default on all platforms for the 0.12.0 release
  • Loading branch information
pshipton committed Jan 10, 2019
2 parents ad6dd24 + b70bc3d commit bcee0ea
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
9 changes: 7 additions & 2 deletions runtime/oti/j9.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 1991, 2018 IBM Corp. and others
* Copyright (c) 1991, 2019 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -328,7 +328,12 @@ static const struct { \
#endif /* J9VM_OPT_VALHALLA_VALUE_TYPES */

#if defined(OPENJ9_BUILD)
#define J9_SHARED_CACHE_DEFAULT_BOOT_SHARING(vm) TRUE
/* Disable the sharedclasses by default feature due to performance regressions
* found prior to the 0.12.0 release. Enabling the cache for bootstrap classes
* only interacts poorly with the JIT's logic to disable the iprofiler if a
* warm cache is detected. See https://github.com/eclipse/openj9/issues/4222
*/
#define J9_SHARED_CACHE_DEFAULT_BOOT_SHARING(vm) FALSE
#else /* defined(OPENJ9_BUILD) */
#define J9_SHARED_CACHE_DEFAULT_BOOT_SHARING(vm) FALSE
#endif /* defined(OPENJ9_BUILD) */
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>

<!--
Copyright (c) 2016, 2018 IBM Corp. and others
Copyright (c) 2016, 2019 IBM Corp. and others
This program and the accompanying materials are made available under
the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -381,6 +381,11 @@
</test>
<test>
<testCaseName>ShareClassesCMLOpenJ9</testCaseName>
<disabled>
SharedClasses by default is disabled from the 0.12.0 release while we
work through some performance issues related to lost iprofiler data.
See issue: https://github.com/eclipse/openj9/issues/4222
</disabled>
<variations>
<variation>Mode110</variation>
<variation>Mode610</variation>
Expand Down

0 comments on commit bcee0ea

Please sign in to comment.