Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SCC by default on all platforms for the 0.12.0 release #4227

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

DanHeidinga
Copy link
Member

@DanHeidinga DanHeidinga commented Jan 10, 2019

Opening the issue now so testing can be run to ensure that no additional changes are required to disable SCC by default.

issue: #4222

Doc issue: eclipse-openj9/openj9-docs#187

Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com

@DanHeidinga
Copy link
Member Author

Jenkins test all plinux,xlinux,win jdk8

issue: eclipse-openj9#4222

Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
@DanHeidinga
Copy link
Member Author

I've got a fix for the copyright failure but want to see the testing run first

@DanHeidinga
Copy link
Member Author

Sanity failure is due to a test that assumes that bootstrap sharing is enabled:

ShareClassesCMLOpenJ9_1

Test will be re-enabled when the performance issues are worked out.

issue: eclipse-openj9#4227

Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
@DanHeidinga
Copy link
Member Author

Note, the extended testing for plinux,xlinux,win jdk8 all passed. The results will be lost when I force push the commit disabling the test.

@DanHeidinga
Copy link
Member Author

Jenkins test sanity zlinux jdk8

@DanHeidinga
Copy link
Member Author

Running a single sanity build to validate there are no other failures related to this issue.

We can run additional testing before review / merge once we know this is good.

@pshipton pshipton merged commit bcee0ea into eclipse-openj9:master Jan 10, 2019
pshipton added a commit to pshipton/openj9 that referenced this pull request Jun 25, 2019
Issue eclipse-openj9#5831
Reverts eclipse-openj9#4227

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants