-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xlpCodeCacheTests_1 failing on AIX XL #11104
Comments
@llxia I think this test was recently added? I expect it's incorrect somehow and should recognize 64K as the default for AIX. It's failing on IBM Java 8 as well (32-bit and 64-bit AIX) from Oct 29th (no previous history). Also, let's run it in the default mode instead of 109, 110. There are likely many tests that need a mode change, but I can open another issue. |
I didn't see it at first, actually I think this is a bug in some JIT/port/verbose code since it's not listing 64K as a possible size although it's the default.
|
Just for the record, this test was ported recently (PR #10980) xlpCodeCacheTests_0 passed with Mode109 |
@gita-omr can you please take a look at this? see #11104 (comment) |
If the test case was just added and seems to expose old issues which we are planning to rework anyway, maybe it should not be a blocker? @AlenBadel fyi |
I believe this is an issue I've already addressed on my re-work branch. This does not impact performance or functionality at all, rather it's just a bug in the verbose log which the test uses to verify the correct page configuration. In any matter, I'll be more than happy to create a PR to fix this verbose bug. |
Sorry for sounding trivial but every change takes time and we don't know how it is going to affect other Xlp tests. I would rather us finish our other blockers. |
Issue eclipse-openj9#11104 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Test will be excluded via #11460. |
Issue eclipse-openj9#11104 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
with Alen leaving IBM, we will look into this in the next round. |
AIX default pagesize is 4KB (whereas Linux default pagesize is 64KB). How does the test case expect AIX codecache default pagesize to be 64KB? through other setting(s)? |
there are linker options to set these "default" pagesize(s) (on AIX only). i didn't see they are used in the makefile though. |
as far as i can see, this is a preference testing. i.e. you can say 64KB page is the preference when 16MB page support is not available. let Amar chase this down ... |
Is it set to 64k here? openj9/runtime/compiler/control/J9Options.cpp Line 1821 in fc324bb
|
yeah, it makes sense from -Xlp preference perspective (when 16MB is not available). |
Re-enable xlpCodeCacheTests on AIX and fix typo in XlpCodeCacheOptionsTestRunner. Closes: eclipse-openj9#11104 Signed-off-by: Amarpreet Singh amarpreet1997@gmail.com
Re-enable xlpCodeCacheTests on AIX and fix typo in XlpCodeCacheOptionsTestRunner. Closes: eclipse-openj9#11104 Signed-off-by: Amarpreet Singh amarpreet1997@gmail.com
https://ci.eclipse.org/openj9/job/Test_openjdk8_j9_extended.functional_ppc64_aix_xl_Personal/1
xlpCodeCacheTests_1
Note this only fails on XL because it only runs on XL due to the test modes. FYI #11105
The text was updated successfully, but these errors were encountered: