Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JDK18] j.l.Error: TESTBUG: unsupported vm variant #14079

Closed
babsingh opened this issue Dec 6, 2021 · 5 comments · Fixed by ibmruntimes/openj9-openjdk-jdk#390 or ibmruntimes/openj9-openjdk-jdk18#4

Comments

@babsingh
Copy link
Contributor

babsingh commented Dec 6, 2021

OpenJDK Tests

TEST: java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java

Error

[2021-11-17T18:49:53.434Z] java.lang.Error: TESTBUG: unsupported vm variant
[2021-11-17T18:49:53.434Z]      at jdk.test.lib.Platform.variant(Platform.java:370)
[2021-11-17T18:49:53.434Z]      at jdk.test.lib.Platform.jvmLibDir(Platform.java:357)
[2021-11-17T18:49:53.434Z]      at CallerAccessTest.main(CallerAccessTest.java:53)
[2021-11-17T18:49:53.434Z]      at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[2021-11-17T18:49:53.434Z]      at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:76)
[2021-11-17T18:49:53.434Z]      at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:52)
[2021-11-17T18:49:53.434Z]      at java.base/java.lang.reflect.Method.invoke(Method.java:577)
[2021-11-17T18:49:53.434Z]      at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
[2021-11-17T18:49:53.434Z]      at java.base/java.lang.Thread.run(Thread.java:884)

Related: #13946

@babsingh babsingh added this to the Release 0.31 (Java 18) milestone Dec 6, 2021
babsingh added a commit to babsingh/aqa-tests that referenced this issue Dec 6, 2021
babsingh added a commit to babsingh/aqa-tests that referenced this issue Dec 6, 2021
llxia pushed a commit to adoptium/aqa-tests that referenced this issue Dec 7, 2021
@babsingh
Copy link
Contributor Author

exeCallerAccessTest/CallerAccessTest has already been excluded due to adoptium/temurin-build#248.

Test exclusion in aqa-tests: https://github.com/adoptium/aqa-tests/blob/253c7bf6fb188ca14c46bc13b2cc5426e13a12ea/openjdk/excludes/ProblemList_openjdk18-openj9.txt#L134

In adoptium/temurin-build#248, I did not find an explicit reason for excluding this test.

@llxia @sophia-guo @smlambert why was exeCallerAccessTest/CallerAccessTest excluded in adoptium/temurin-build#248? Is this test not compatible with OpenJ9 -- Error: TESTBUG: unsupported vm variant?

babsingh added a commit to babsingh/aqa-tests that referenced this issue Jan 12, 2022
- eclipse-openj9/openj9#14079 is a duplicate of adoptium/temurin-build#248.
- eclipse-openj9/openj9#14091 is a duplicate of adoptium#1297.
- eclipse-openj9/openj9#14095 is a duplicate of eclipse-openj9/openj9#11930.
- Individual sub-tests of StringBuilder/HugeCapacity are excluded.

Closes: eclipse-openj9/openj9#14079
Closes: eclipse-openj9/openj9#14091
Closes: eclipse-openj9/openj9#14095

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@llxia
Copy link
Contributor

llxia commented Jan 12, 2022

adoptium/temurin-build#248 is about lacking openjdk test image for JDK11+. This test image issue was closed in Sep 2019, so ideally all exclusions that are due to adoptium/temurin-build#248 should be reenabled. I guess we forget to reenable them? @sophia-guo could you please confirm?

@sophia-guo
Copy link
Contributor

Yes, tests excluded by issue adoptium/temurin-build#248 should be re-enabled as testImage is available and corresponding option -nativepath has also been added.

@babsingh Originally java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java was excluded because testImage was not created and -nativepath option couldn't be added . The error java.lang.Error: TESTBUG: unsupported vm variant is different, which may be specific to openj9.

babsingh added a commit to babsingh/openj9-openjdk-jdk that referenced this issue Jan 13, 2022
babsingh added a commit to babsingh/openj9-openjdk-jdk that referenced this issue Jan 13, 2022
babsingh added a commit to babsingh/openj9-openjdk-jdk18 that referenced this issue Jan 13, 2022
babsingh added a commit to babsingh/openj9-openjdk-jdk that referenced this issue Jan 13, 2022
isServer() updated to return true if java.vm.name contains openj9 or ibm.

isDefaultCDSArchiveSupported() updated to return false if java.vm.name contains
openj9 or ibm since J9 does not support the default CDS archive.

This is an updated fix for eclipse-openj9/openj9#14079.

Related: ibmruntimes#390

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh added a commit to babsingh/openj9-openjdk-jdk that referenced this issue Jan 13, 2022
isServer() updated to return true if java.vm.name contains OpenJ9 or IBM.

isDefaultCDSArchiveSupported() updated to return false if java.vm.name contains
OpenJ9 or IBM since J9 does not support the default CDS archive.

This is an updated fix for eclipse-openj9/openj9#14079.

Related: ibmruntimes#390

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh added a commit to babsingh/openj9-openjdk-jdk18 that referenced this issue Jan 13, 2022
isServer() updated to return true if java.vm.name contains OpenJ9 or IBM.

isDefaultCDSArchiveSupported() updated to return false if java.vm.name contains
OpenJ9 or IBM since J9 does not support the default CDS archive.

This is an updated fix for eclipse-openj9/openj9#14079.

Related: ibmruntimes/openj9-openjdk-jdk#390

Backport: ibmruntimes/openj9-openjdk-jdk#391

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@pshipton
Copy link
Member

@babsingh are you able to remove labels? The "test excluded" label should be removed now that it's not excluded any more.

@babsingh
Copy link
Contributor Author

are you able to remove labels? The "test excluded" label should be removed now that it's not excluded any more.

Yes. The test excluded label has been removed.

@babsingh babsingh self-assigned this Jan 17, 2022
babsingh added a commit to babsingh/openj9-openjdk-jdk17 that referenced this issue Feb 4, 2022
isServer() updated to return true if java.vm.name contains OpenJ9 or IBM.

isDefaultCDSArchiveSupported() updated to return false if java.vm.name contains
OpenJ9 or IBM since J9 does not support the default CDS archive.

This is an updated fix for eclipse-openj9/openj9#14079.

Related: ibmruntimes/openj9-openjdk-jdk#390

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh added a commit to babsingh/openj9-openjdk-jdk17 that referenced this issue Feb 4, 2022
isServer() updated to return true if java.vm.name contains OpenJ9 or IBM.

isDefaultCDSArchiveSupported() updated to return false if java.vm.name contains
OpenJ9 or IBM since J9 does not support the default CDS archive.

This is an updated fix for eclipse-openj9/openj9#14079.

Related: ibmruntimes/openj9-openjdk-jdk#390

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment