Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JDK18 test exclude list #3211

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Update JDK18 test exclude list #3211

merged 2 commits into from
Jan 13, 2022

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Jan 12, 2022 •
edited
Loading

Commit 1: [JDK18] Remove duplicates and exclude sub-tests

-- eclipse-openj9/openj9#14091 is a duplicate of #1297.
-- eclipse-openj9/openj9#14095 is a duplicate of eclipse-openj9/openj9#11930.
-- Individual sub-tests of StringBuilder/HugeCapacity are excluded.

Closes: eclipse-openj9/openj9#14091
Closes: eclipse-openj9/openj9#14095

Commit 2: [JDK18] Re-enable exeCallerAccessTest/CallerAccessTest

Fixed by ibmruntimes/openj9-openjdk-jdk18#4.
Also, adoptium/temurin-build#248 has been closed.
Now, exeCallerAccessTest/CallerAccessTest passes with OpenJ9 JDK18.

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

@babsingh
Copy link
Contributor Author

Reviewers: @llxia @Mesbah-Alam
fyi: @pshipton @tajila

@babsingh
Copy link
Contributor Author

In eclipse-openj9/openj9#14079 (comment), I had a question for the test team:

In adoptium/temurin-build#248, I did not find an explicit reason for excluding this test. Why was exeCallerAccessTest/CallerAccessTest excluded in adoptium/temurin-build#248? Is this test not compatible with OpenJ9 -- Error: TESTBUG: unsupported vm variant?

This PR will close eclipse-openj9/openj9#14079. Requesting test team to respond to this question in eclipse-openj9/openj9#14079 before merging this PR.

@llxia
Copy link
Contributor

llxia commented Jan 12, 2022

Not sure eclipse-openj9/openj9#14079 is a duplicate of adoptium/temurin-build#248. Raising the question at eclipse-openj9/openj9#14079 (comment)

@babsingh babsingh force-pushed the master branch 2 times, most recently from a1ac005 to 31e5bbb Compare January 13, 2022 04:01
@babsingh
Copy link
Contributor Author

I have updated the PR. eclipse-openj9/openj9#14079 is no longer treated as a duplicate of adoptium/temurin-build#24. As per eclipse-openj9/openj9#14079 (comment), all tests disabled for adoptium/temurin-build#248 have been re-enabled. fyi @llxia @sophia-guo.

@babsingh babsingh changed the title Remove duplicates and exclude sub-tests Update test exclude lists Jan 13, 2022
@llxia
Copy link
Contributor

llxia commented Jan 13, 2022 •
edited
Loading

Thanks @babsingh for reenabling all tests that are excluded due to 248. However, IMHO, it may be better to enable these tests step by step after proper testing (in a separate issue/PR #3214) as these tests have been excluded for a long time for both openj9 and hotspot (some of them have been excluded since JDK10) and we are going to have a release soon.

FYI @smlambert

@babsingh
[JDK18] Remove duplicates and exclude sub-tests
2c4f0ec 
- eclipse-openj9/openj9#14091 is a duplicate of adoptium#1297.
- eclipse-openj9/openj9#14095 is a duplicate of eclipse-openj9/openj9#11930.
- Individual sub-tests of StringBuilder/HugeCapacity are excluded.

Closes: eclipse-openj9/openj9#14091
Closes: eclipse-openj9/openj9#14095

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
[JDK18] Re-enable exeCallerAccessTest/CallerAccessTest
eee1dc7 
Fixed by ibmruntimes/openj9-openjdk-jdk18#4.
Also, adoptium/temurin-build#248 has been closed.
Now, exeCallerAccessTest/CallerAccessTest passes with OpenJ9 JDK18.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor Author

babsingh commented Jan 13, 2022 •
edited
Loading

re #3211 (comment):

You are correct. Yesterday, I ran exeCallerAccessTest/CallerAccessTest, and it failed even though adoptium/temurin-build#248 has been closed. More work may be needed to re-enable the tests disabled for adoptium/temurin-build#248. [Old commit 2] I have removed the commit which re-enabled the tests associated with adoptium/temurin-build#248. [New commit 2] I have only re-enabled exeCallerAccessTest/CallerAccessTest, which has been fixed for OpenJ9 JDK18.

@babsingh babsingh changed the title Update test exclude lists Update JDK18 test exclude list Jan 13, 2022
llxia
llxia approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @babsingh

LongyuZhang
LongyuZhang approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 79026fa into adoptium:master Jan 13, 2022
@pshipton pshipton mentioned this pull request Jan 14, 2022
Merged
This was referenced Jan 14, 2022
Merged
Closed
smlambert pushed a commit that referenced this pull request Jan 15, 2022
@babsingh
[JDK18] Correctly exclude StringBuilder/HugeCapacity (#3220)
39c1848 
Excluding StringBuilder/HugeCapacity sub-tests does not work.

So, the StringBuilder/HugeCapacity changes in #3211 have
been reverted.

The original StringBuilder/HugeCapacity exclude change has been re-added.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JDK18] UncaughtExceptionsTest failure [JDK18] OutOfMemoryError from StringBuilder/HugeCapacity.java
3 participants
@babsingh @llxia @LongyuZhang