Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JDK19] JVMTI GetVirtualThread #16203

Closed
babsingh opened this issue Oct 26, 2022 · 3 comments
Closed

[JDK19] JVMTI GetVirtualThread #16203

babsingh opened this issue Oct 26, 2022 · 3 comments
Assignees
@babsingh
Labels
comp:jvmti comp:vm jdk19 jdk20 project:loom Used to track Project Loom related work
Milestone
Java 20.0.2

Comments

@babsingh
Copy link
Contributor

babsingh commented Oct 26, 2022 •
edited
Loading

JVMTI GetVirtualThread is part of the JVMTI Extension API, which is not covered by the JVMTI documentation. So, it doesn't need to be supported for the current Java 19 milestone.

GetVirtualThread just returns the virtual thread object corresponding to a carrier thread via one of the input parameters. It's the inverse of GetCarrierThread (see #16168).

The following JVMTI serviceability tests will need to be disabled until support for GetVirtualThread is introduced:

serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java
serviceability/jvmti/vthread/VThreadTest/VThreadTest.java
serviceability/jvmti/vthread/MethodExitTest/MethodExitTest.java

serviceability/jvmti/stress/ThreadLocalStorage/SetGetThreadLocalStorageStressTest/SetGetThreadLocalStorageStressTest.java
serviceability/jvmti/stress/StackTrace/Suspended/GetStackTraceSuspendedStressTest.java
serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java

Related: #16187

Excluded via adoptium/aqa-tests#4087.
@babsingh babsingh mentioned this issue Oct 31, 2022
Closed
@pshipton pshipton added the jdk19 label Nov 1, 2022
@babsingh babsingh added the project:loom Used to track Project Loom related work label Nov 1, 2022
@babsingh babsingh mentioned this issue Nov 1, 2022
Closed
@babsingh
Copy link
Contributor Author

babsingh commented Nov 1, 2022

@JasonFengJ9 @fengxue-IS I have updated the list of tests impacted by JVMTI GetVirtualThread. They will need to be excluded.

@JasonFengJ9 JasonFengJ9 mentioned this issue Nov 7, 2022
Merged
@JasonFengJ9
Copy link
Member

Created adoptium/aqa-tests#4122 to exclude following tests:

serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithBacktrace.java
serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java
serviceability/jvmti/stress/StackTrace/Suspended/GetStackTraceSuspendedStressTest.java

@babsingh babsingh mentioned this issue Jan 6, 2023
Merged
babsingh added a commit to babsingh/openj9 that referenced this issue Jan 18, 2023
@babsingh
JVMTI Extension Functions: GetVirtualThread and GetCarrierThread
5770f1e 
The following JVMTI extension functions are implemented:
- GetVirtualThread: Gets the virtual thread corresponding to a
  carrier thread.
- GetCarrierThread: Gets the carrier thread corresponding to a
  virtual thread.

Fixes: eclipse-openj9#16168
Fixes: eclipse-openj9#16203

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh self-assigned this Jan 18, 2023
babsingh added a commit to babsingh/openj9 that referenced this issue Jan 18, 2023
@babsingh
JVMTI Extension Functions: GetVirtualThread and GetCarrierThread
8e5940c 
The following JVMTI extension functions are implemented:
- GetVirtualThread: Gets the virtual thread corresponding to a
  carrier thread.
- GetCarrierThread: Gets the carrier thread corresponding to a
  virtual thread.

Related: eclipse-openj9#16168
Related: eclipse-openj9#16203

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@tajila tajila modified the milestones: Java 20.0.1 0.39?, Java 20.0.2 Apr 11, 2023
@babsingh babsingh mentioned this issue Apr 28, 2023
Closed
@babsingh
Copy link
Contributor Author

babsingh commented May 1, 2023

The JVMTI GetVirtualThread extension function is implemented in #16518.

For JDK20, no test is disabled due to this issue in https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk20-openj9.txt.

Thus, closing this issue.

@babsingh babsingh closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@babsingh babsingh

Labels
comp:jvmti comp:vm jdk19 jdk20 project:loom Used to track Project Loom related work
Projects
None yet
Milestone
Java 20.0.2
Development

No branches or pull requests
4 participants
@babsingh @tajila @JasonFengJ9 @pshipton