Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove java.lang.Compiler from Java 21+ #18430

Closed
keithc-ca opened this issue Nov 9, 2023 · 3 comments · Fixed by #18582
Closed

Remove java.lang.Compiler from Java 21+ #18430

keithc-ca opened this issue Nov 9, 2023 · 3 comments · Fixed by #18582
Assignees
@keithc-ca
Labels
jdk21
Milestone
Java 21 (0.42)

Comments

@keithc-ca
Copy link
Contributor

keithc-ca commented Nov 9, 2023 •
edited by pshipton
Loading

It was removed upstream via openjdk/jdk@a8e3a2d.

Also the following

core-libs/java.lang
➜ Removal of the java.compiler System Property (JDK-8041676)

The system property java.compiler has been removed from the list of standard system properties.

Running with this system property set on the command line will now print a warning to say that the system property is obsolete; it has no other effect. In previous releases, running with -Djava.compiler or -Djava.compiler=NONE on the command line selected interpreter only execution mode. If needed, the -Xint option can be used to run in interpreter only mode.
@keithc-ca keithc-ca added the jdk21 label Nov 9, 2023
@keithc-ca keithc-ca self-assigned this Nov 9, 2023
@pshipton
Copy link
Member

pshipton commented Nov 9, 2023

Did you mean 22+, why do you expect jdk21 to change? Since it's GAed it would be weird to remove something from the spec now.

@keithc-ca
Copy link
Contributor Author

You'll notice the commit I referenced is from April. The change is included in jdk21-ga (you won't see Compiler.java in https://github.com/openjdk/jdk/tree/jdk-21-ga/src/java.base/share/classes/java/lang).

@keithc-ca keithc-ca added jdk21 and removed jdk21 labels Nov 22, 2023
@keithc-ca keithc-ca mentioned this issue Dec 6, 2023
Merged
@pshipton pshipton added this to the Java 21 (0.42) milestone Dec 6, 2023
@keithc-ca
Copy link
Contributor Author

We agreed to keep this open; see #18571 (comment).

@keithc-ca keithc-ca reopened this Dec 6, 2023
keithc-ca added a commit to keithc-ca/openj9 that referenced this issue Dec 7, 2023
@keithc-ca
Remove java.lang.Compiler for Java 21+
f76c7ad 
Fixes: eclipse-openj9#18430

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
keithc-ca added a commit to keithc-ca/openj9 that referenced this issue Dec 7, 2023
@keithc-ca
Remove java.lang.Compiler for Java 21+
131a82d 
Fixes: eclipse-openj9#18430

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@pshipton pshipton mentioned this issue Dec 8, 2023
Merged
pshipton added a commit to pshipton/openj9 that referenced this issue Dec 8, 2023
@pshipton
The java.compiler system property is obsolete in jdk21+
f88cf9e 
Issue eclipse-openj9#18430

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton added a commit to pshipton/openj9 that referenced this issue Dec 8, 2023
@pshipton
The java.compiler system property is obsolete in jdk21+
d51767b 
Issue eclipse-openj9#18430

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton added a commit to pshipton/openj9 that referenced this issue Dec 8, 2023
@pshipton
The java.compiler system property is obsolete in jdk21+
6a618c5 
Issue eclipse-openj9#18430

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
This was referenced Dec 8, 2023
Merged
Merged
@hangshao0 hangshao0 mentioned this issue Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithc-ca keithc-ca

Labels
jdk21
Projects
None yet
Milestone
Java 21 (0.42)
Development

Successfully merging a pull request may close this issue.

The java.compiler system property is obsolete in jdk21+ pshipton/openj9
2 participants
@keithc-ca @pshipton