Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing compression checks in private String constructor #777

Closed
fjeremic opened this issue Dec 7, 2017 · 0 comments
Closed

Add missing compression checks in private String constructor #777

fjeremic opened this issue Dec 7, 2017 · 0 comments
Labels
comp:jit comp:vm

Comments

@fjeremic
Copy link
Contributor

fjeremic commented Dec 7, 2017 •
edited
Loading

There seem to be missing compression checks in code that deals with toUpper and toLower. The call a private String(I) constructor seen in

https://github.com/eclipse/openj9/blob/f15d63a353a71b651e3d866612e02d3d94426462/jcl/src/java.base/share/classes/java/lang/String.java#L1230-L1255

which creates a decompressed String by default. We need to rework this code and determine in which situations we can create compressed Strings.
@mstoodle mstoodle changed the title Add missing compression checks in private String consturctor Add missing compression checks in private String constructor Jan 24, 2018
dhong44 added a commit to dhong44/openj9 that referenced this issue Jul 4, 2018
@dhong44
Remove unnecessary String constructors for toUpper/toLower
99931b0 
Remove unused String constructors accepting one integer
and returning an empty String with an appropriate capacity.

Closes: eclipse-openj9#777

Signed-off-by: Daniel Hong <daniel.hong@live.com>
@dhong44 dhong44 mentioned this issue Jul 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:jit comp:vm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fjeremic