Re-enable toLowerCase/toUpperCase acceleration #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify API call so that caseConversionHelper recieves underlying arrays and length of string. Closes: eclipse-openj9#1934 Signed-off-by: Daniel Hong <daniel.hong@live.com>
Remove unused String constructors accepting one integer and returning an empty String with an appropriate capacity. Closes: eclipse-openj9#777 Signed-off-by: Daniel Hong <daniel.hong@live.com>
|
@fjeremic Could I get a review please |
|
This is a copy of #2098 which was merged accidentally before running testing. Let's do some tests now... Jenkins test sanity |
|
Windows tests failing with: Looks like infrastructure issues. |
fjeremic
approved these changes
Jul 5, 2018
fjeremic
added a commit
to fjeremic/openj9
that referenced
this pull request
Feb 12, 2019
In eclipse-openj9#4597 we identified cases on which `toUpperCase` fails on Linux on Z. This is due to some faulty login in the evaluator for these intrinsics on Z. Bugs seem to have been introduced in eclipse-openj9#2318 for certain characters. Namely the test in eclipse-openj9#4597 fails to convert the `\u00FF` character. The bug is obvious, since `toUpperCase` of such a character cannot be handled and the JIT evaluator determines the invalid character range by checking if the character is greater than 0xFF, but it should be checking if greater than or equal to. In addition the compressed String evaluator also fails on 0xB5 as determined by the unit tests. Both issues are fixed. Fixes: eclipse-openj9#4597 Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify API call so that caseConversionHelper receives
underlying arrays and length of string.
Closes: #1934
Closes: #777
Signed-off-by: Daniel Hong daniel.hong@live.com