Add -Xcheck:jni mismatching field check - static vs non-static #10229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added JNIC_JFIELDSTATICID to indicate a static field ID; Added JNIC_JFIELDINSTANCEID to indicate a non-static field ID; Added J9NLS_JNICHK_NON_STATIC_FIELDID_PASSED for an error that a field is expected to be static but a non-static field ID was passed; Added J9NLS_JNICHK_STATIC_FIELDID_PASSED for an error that a field is expected to be non-static but a static field ID was passed; Invoke jniCheckFatalErrorNLS() accordingly; Added tests. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
|
@gacholio could you please review? |
gacholio
approved these changes
Jul 23, 2020
|
jenkins test sanity,extended win jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
JNIC_JFIELDSTATICIDto indicate a static field ID;Added
JNIC_JFIELDINSTANCEIDto indicate a non-static field ID;Added
J9NLS_JNICHK_NON_STATIC_FIELDID_PASSEDfor an error that a field is expected to be static but a non-static field ID was passed;Added
J9NLS_JNICHK_STATIC_FIELDID_PASSEDfor an error that a field is expected to be non-static but a static field ID was passed;Invoke
jniCheckFatalErrorNLS()accordingly;Added tests.
closes: #10210
Signed-off-by: Jason Feng fengj@ca.ibm.com