Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable j2iInvokeExact and i2jMHTransition for OpenJ9 MHs #11290

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Nov 26, 2020

In other words, j2iInvokeExact and i2jMHTransition have been disabled
for OpenJDK MHs.

Related: #7352

Co-authored-by: Jack Lu Jack.S.Lu@ibm.com
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

In other words, j2iInvokeExact and i2jMHTransition have been disabled
for OpenJDK MHs.

Co-authored-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh marked this pull request as draft November 26, 2020 23:43
@DanHeidinga DanHeidinga added the project:MH Used to track Method Handles related work label Nov 27, 2020
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming this will be removed eventually

@DanHeidinga
Copy link
Member

Jenkins test sanity plinux,win jdk8

@DanHeidinga DanHeidinga self-assigned this Nov 27, 2020
@babsingh
Copy link
Contributor Author

Tested a local build with OpenJDK MHs enabled; these changes are good; removing WIP.

assuming this will be removed eventually

yes, these changes will be removed along with all other OpenJ9 MH dependencies once OpenJDK MH is accepted and enabled across all OpenJ9 JDK versions.

@babsingh babsingh marked this pull request as ready for review November 27, 2020 14:47
@DanHeidinga DanHeidinga merged commit cb2ed13 into eclipse-openj9:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:MH Used to track Method Handles related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants