-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable java.lang.Class.getConstantPool() for Java 8 #11370
Conversation
Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @JasonFengJ9! @tajila this should be ready to build/merge. The Copyright Check failure appears to be a pipeline problem, as the file already includes the correct year. |
Jenkins test sanity plinux jdk8 |
Jenkins test sanity,extended zlinux jdk11 |
Copyright check failed with
@AdamBrousseau is there a way to trigger another run? |
Jenkins copyright check |
Thanks @AdamBrousseau |
@sharon-wang you'll need to deliver this to the 0.24 branch as well since we have already split. |
Actually as it's the next commit, I can just push it. |
Pushed c144b7c to the v0.24.0-release branch. |
Thanks Peter |
However note this change isn't included in the Milestone1 builds, which are created from the tags on the original branched content. |
Should resolve #11271.
RI exposes
java.lang.Class.getConstantPool()
for Java 8 -- we are matching this.