Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable java.lang.Class.getConstantPool() for Java 8 #11370

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

sharon-wang
Copy link
Contributor

Should resolve #11271.

RI exposes java.lang.Class.getConstantPool() for Java 8 -- we are matching this.

Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
Copy link
Member

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharon-wang
Copy link
Contributor Author

Thanks @JasonFengJ9!

@tajila this should be ready to build/merge. The Copyright Check failure appears to be a pipeline problem, as the file already includes the correct year.

@tajila
Copy link
Contributor

tajila commented Dec 4, 2020

Jenkins test sanity plinux jdk8

@tajila
Copy link
Contributor

tajila commented Dec 4, 2020

Jenkins test sanity,extended zlinux jdk11

@tajila
Copy link
Contributor

tajila commented Dec 4, 2020

Copyright check failed with

16:27:28  	at java.lang.Thread.run(Thread.java:748)
16:27:28  	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to worker-1
16:27:28  		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1788)
16:27:28  		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
16:27:28  		at hudson.remoting.Channel.call(Channel.java:998)
16:27:28  		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
16:27:28  		at sun.reflect.GeneratedMethodAccessor575.invoke(Unknown Source)
16:27:28  		at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
16:27:28  		at java.lang.reflect.Method.invoke(Unknown Source)
16:27:28  		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
16:27:28  		at com.sun.proxy.$Proxy84.execute(Unknown Source)
16:27:28  		at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:994)
16:27:28  		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1237)
16:27:28  		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1297)
16:27:28  		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:125)
16:27:28  		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)
16:27:28  		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)
16:27:28  		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
16:27:28  		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$$Lambda$370/0000000048425AC0.run(Unknown Source)
16:27:28  		at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
16:27:28  		at java.util.concurrent.FutureTask.run(Unknown Source)
16:27:28  		at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
16:27:28  		at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
16:27:28  		at java.lang.Thread.run(Unknown Source)
[Pipeline] }

@AdamBrousseau is there a way to trigger another run?

@AdamBrousseau
Copy link
Contributor

Jenkins copyright check

@tajila
Copy link
Contributor

tajila commented Dec 5, 2020

Thanks @AdamBrousseau

@tajila tajila merged commit c144b7c into eclipse-openj9:master Dec 7, 2020
@tajila
Copy link
Contributor

tajila commented Dec 7, 2020

@sharon-wang you'll need to deliver this to the 0.24 branch as well since we have already split.

@pshipton
Copy link
Member

pshipton commented Dec 7, 2020

Actually as it's the next commit, I can just push it.

@pshipton
Copy link
Member

pshipton commented Dec 7, 2020

Pushed c144b7c to the v0.24.0-release branch.

@tajila
Copy link
Contributor

tajila commented Dec 7, 2020

Thanks Peter

@pshipton
Copy link
Member

pshipton commented Dec 7, 2020

However note this change isn't included in the Milestone1 builds, which are created from the tags on the original branched content.

@sharon-wang sharon-wang deleted the getcp branch December 16, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibilities with Minecraft 1.12 Mod "Valkyrien Skies"
5 participants