Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v0.24.0-release) jdk.internal.access.SharedSecrets is required for JDK15+ #11473

Merged

Conversation

JasonFengJ9
Copy link
Member

jdk.internal.misc.SharedSecrets is for JDK11;
sun.misc.SharedSecrets is for JDK8.

Cherry-picked from #11389

Signed-off-by: Jason Feng fengj@ca.ibm.com

jdk.internal.misc.SharedSecrets is for JDK11;
sun.misc.SharedSecrets is for JDK8.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9
Copy link
Member Author

@pshipton could you please review?

@tajila
Copy link
Contributor

tajila commented Dec 13, 2020

Jenkins test sanity plinux jdk11

@pshipton
Copy link
Member

@tajila fyi your PR build as specified doesn't pick up the OMR or JCL 0.24 levels, it uses the default branches. You'd need to specify the release branches using the depends keyword. Anyway, as this is the same change applied to master I'm not going to bother with additional PR testing.

@pshipton
Copy link
Member

Also note the problem is jdk15 specific.

@pshipton pshipton merged commit 2312097 into eclipse-openj9:v0.24.0-release Dec 14, 2020
@JasonFengJ9 JasonFengJ9 deleted the v24sharedsecrets branch January 8, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants