Clean up StringTable code #11700
Merged
Clean up StringTable code #11700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Jan 19, 2021
|
jenkins test sanity,extended,sanity.openjdk zlinux jdk11 |
|
jenkins compile win jdk8 |
|
- inline various functions that were only ever used here (and should never be used anywhere else) - remove J9_STR_ASCII which was added solely to communicate to one of the now-inlined functions - replace repeated bit tests with boolean variables [ci skip] Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
|
Windows errors fixed. |
|
jenkins compile win jdk8 |
pshipton
approved these changes
Jan 20, 2021
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Nov 30, 2021
j9gc_createJavaLangString() must use the Unicode length when checking if a Unicode string is ASCII or Latin 1. Bug introduced by eclipse-openj9#11700 in 0.25 although there was a different but similar problem in previous releases. Issue eclipse-openj9#13655 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Nov 30, 2021
j9gc_createJavaLangString() must use the Unicode length when checking if a Unicode string is ASCII or Latin 1. Bug introduced by eclipse-openj9#11700 in 0.25 although there was a different but similar problem in previous releases. Issue eclipse-openj9#13655 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
never be used anywhere else)
the now-inlined functions
[ci skip]
Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com