Refactor content of j9ddr.jar into openj9.dtfj module #11735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add exports & requires clauses for openj9.dtfjview * adjust exports in ImageFactory - programmatically export com.ibm.j9ddr and select sub-packages * move stub for ZFile to openj9.dtfj * remove unused module-info.java for ibm.jzos Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
This was referenced Jan 21, 2021
Merged
Merged
pshipton
reviewed
Jan 21, 2021
* update precondition: look for j9ddr.dat instead of j9ddr.jar * build with j9ddr.jar for Java 8, --add-exports for newer versions * update runtime classpath (include j9ddr.jar only for Java 8) * update exports for newer versions Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
Updated test build script and added |
|
Jenkins test sanity,extended zlinux jdk8 depends ibmruntimes/openj9-openjdk-jdk8#472 |
|
Jenkins test sanity,extended zlinux jdknext depends ibmruntimes/openj9-openjdk-jdk#272 |
|
Jenkins test sanity,extended zlinux jdk11 depends ibmruntimes/openj9-openjdk-jdk11#380 |
|
@keithc-ca note you can only specify one PR build command per comment. |
|
Jenkins test sanity,extended zlinux jdk16 depends ibmruntimes/openj9-openjdk-jdk16#10 |
|
Jenkins test sanity,extended plinux jdk16 depends ibmruntimes/openj9-openjdk-jdk16#10 |
|
zlinux machines were having a problem #11781 so testing jdk16 on plinux instead. |
pshipton
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openj9.dtfjviewImageFactory: programmatically exportcom.ibm.j9ddrand select sub-packagesZFiletoopenj9.dtfjmodule-info.javaforibm.jzosIssue #11464