Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable J9-specific HCR code in OJDK implementation #12806

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Disable J9-specific HCR code in OJDK implementation #12806

merged 1 commit into from
Jun 1, 2021

Conversation

EricYangIBM
Copy link
Contributor

Disable fixDirectHandles when building for OJDK method handles.

Issue: #11528
Signed-off-by: Eric Yang eric.yang@ibm.com

@EricYangIBM
Disable J9-specific HCR code in OJDK implementation
7fae476 
Disable fixDirectHandles when building for OJDK method handles.

Issue: eclipse-openj9#11528
Signed-off-by: Eric Yang <eric.yang@ibm.com>
@EricYangIBM EricYangIBM added the project:MH Used to track Method Handles related work label Jun 1, 2021
@babsingh babsingh requested a review from gacholio June 1, 2021 18:27
@babsingh
Copy link
Contributor

babsingh commented Jun 1, 2021

@gacholio Can you please review this HCR related PR? Cmds to run OJDK MH builds:

// Only for compiling
jenkins compile winojdk292,xlinuxojdk292 jdk16 depends ibmruntimes/openj9-openjdk-jdk16#29

// For compiling + testing
jenkins test sanity winojdk292,xlinuxojdk292 jdk16 depends ibmruntimes/openj9-openjdk-jdk16#29

@gacholio
Copy link
Contributor

gacholio commented Jun 1, 2021

This is still draft.

@EricYangIBM EricYangIBM changed the title [WIP] Disable J9-specific HCR code in OJDK implementation Disable J9-specific HCR code in OJDK implementation Jun 1, 2021
@EricYangIBM EricYangIBM marked this pull request as ready for review June 1, 2021 18:49
@EricYangIBM
Copy link
Contributor Author

This is still draft.

@gacholio Fixed

@gacholio
Copy link
Contributor

gacholio commented Jun 1, 2021

jenkins compile zlinux jdk8

@gacholio
Copy link
Contributor

gacholio commented Jun 1, 2021

jenkins compile xlinuxojdk292 jdk16 depends ibmruntimes/openj9-openjdk-jdk16#29

@gacholio
Copy link
Contributor

gacholio commented Jun 1, 2021

jenkins test sanity winojdk292 jdk16 depends ibmruntimes/openj9-openjdk-jdk16#29

@babsingh
Copy link
Contributor

babsingh commented Jun 1, 2021 •
edited
Loading

https://openj9-jenkins.osuosl.org/job/Test_openjdk16_j9_sanity.functional_x86-64_windows_ojdk292_Personal/2/

@gacholio All failures seen in the above test build are known issues. This PR is good to merge.

https://openj9-jenkins.osuosl.org/job/Test_openjdk16_j9_sanity.functional_x86-64_windows_ojdk292_Personal/2/tapResults/

@llxia TAP Test Results fails to process the full test output on Windows. I had go to through the full console output. Is this a known issue?

@gacholio gacholio merged commit 0a7c5ac into eclipse-openj9:master Jun 1, 2021
This was referenced Jun 3, 2021
Merged
Closed
@EricYangIBM EricYangIBM deleted the disableJ9MH_HCR branch June 3, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

@gacholio gacholio gacholio approved these changes

Assignees
No one assigned
Labels
project:MH Used to track Method Handles related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EricYangIBM @babsingh @gacholio