(0.27.1) Need to consider Portable-AOT cases during code patching #13387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Portable-AOT makes some code sequences different from the expectation of the current CPU type. When that sequence is patched, different possible scenarios have to be considered. Otherwise, doing only according to the current CPU type may run into crashes. Signed-off-by: Julian <zlwang@ca.ibm.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portable-AOT makes some code sequences different from the
expectation of the current CPU type. When that sequence is
patched, different possible scenarios have to be considered.
Otherwise, doing only according to the current CPU type may
run into crashes.
Cherry pick of #13323 for the 0.27.1 release.