Show ignored options in java dumps #13579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove implicit dependency on order of flag bits in prepState and requestMask * add missing parentheses * explicitly compare values with NULL or 0 * initialize local variables * use J9_ARE_ALL_BITS_SET, J9_ARE_ANY_BITS_SET and J9_ARE_NO_BITS_SET where appropriate Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
jenkins test sanity,extended win jdk8 |
2 similar comments
|
jenkins test sanity,extended win jdk8 |
|
jenkins test sanity,extended win jdk8 |
|
The testSoftMxNotDisclaimMemory_3 test failure is a known problem unrelated to this PR. |
pshipton
approved these changes
Sep 29, 2021
|
@keithc-ca pls update the documentation to mention this new feature. |
This was referenced Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit cleans up:
prepStateandrequestMaskNULLor0J9_ARE_ALL_BITS_SET,J9_ARE_ANY_BITS_SETandJ9_ARE_NO_BITS_SETwhere appropriateThe second commit fixes #13471.