Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ignored arguments section in java dumps #865

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

keithc-ca
Copy link
Contributor

As requested.

Also, clean up:

  • collapse multiple blank lines
  • trim trailing whitespace
  • expand tabs

@pshipton
Copy link
Member

Do you think it's worth adding this to the 0.30 release notes?

@keithc-ca
Copy link
Contributor Author

Do you think it's worth adding this to the 0.30 release notes?

Yes, I think so. I'll put that together.

@pshipton
Copy link
Member

We'll also need to create 0.30 release notes in OpenJ9 that list this item, see https://github.com/eclipse-openj9/openj9/tree/master/doc/release-notes

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Nov 23, 2021

See #13976.

@keithc-ca
Copy link
Contributor Author

Rebased and added to 0.30.0 release notes.

@keithc-ca
Copy link
Contributor Author

@pshipton Can you have another look, please?

Include in 0.30.0 release notes.

Also, clean up:
* collapse multiple blank lines
* trim trailing whitespace
* expand tabs

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@pshipton
Copy link
Member

We can't test or publish new docs atm due to UNB machine issues. I will merge and we can fix any undiscovered issues later.

@pshipton pshipton merged commit 39037b4 into eclipse-openj9:master Nov 25, 2021
@keithc-ca keithc-ca deleted the ignored branch November 25, 2021 20:20
@pshipton
Copy link
Member

The new docs are published now. https://eclipse-openj9.github.io/openj9-docs/

I think there should be a link from the release notes to https://eclipse-openj9.github.io/openj9-docs/dump_javadump/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants