Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace classNameToSignature with the define in ClassEnv #13786

Merged

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Oct 26, 2021

Related to eclipse/omr#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo force-pushed the PR-use-classNameToSignature-ClassEnv branch from c8c699c to 6bd31a9 Compare October 27, 2021 03:39
@a7ehuo a7ehuo changed the title WIP: Replace classNameToSignature with the define in ClassEnv Replace classNameToSignature with the define in ClassEnv Oct 29, 2021
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Oct 29, 2021

Remove WIP. Ready for review.

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 29, 2021

Jenkins test sanity all jdk17

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Oct 29, 2021

The failure in Build_JDK17_s390x_linux_Personal looks to be a known issue which is also mentioned in #13828 (comment). This failure also happens in JDKNext build OpenJDK-Acceptance 137.

[2021-10-29T13:56:39.348Z] Exception in thread "main" java.lang.Error: /home/jenkins/workspace/Build_JDK17_s390x_linux_Personal/build/linux-s390x-server-release/support/j9jcl/java.base/share/classes/module-info.java.extra, line 43, multiple exports jdk.internal.misc "exports jdk.internal.misc to openj9.criu ;"
[2021-10-29T13:56:39.348Z] 	at build.tools.module.GenModuleInfoSource$Parser.newError(GenModuleInfoSource.java:770)
[2021-10-29T13:56:39.348Z] 	at build.tools.module.GenModuleInfoSource$ModuleInfo.process(GenModuleInfoSource.java:426)
[2021-10-29T13:56:39.348Z] 	at build.tools.module.GenModuleInfoSource$ModuleInfo.parseExtra(GenModuleInfoSource.java:388)
[2021-10-29T13:56:39.348Z] 	at build.tools.module.GenModuleInfoSource.<init>(GenModuleInfoSource.java:142)
[2021-10-29T13:56:39.348Z] 	at build.tools.module.GenModuleInfoSource.main(GenModuleInfoSource.java:118)
[2021-10-29T13:56:39.348Z] common/modules/GensrcModuleInfo.gmk:82: recipe for target '/home/jenkins/workspace/Build_JDK17_s390x_linux_Personal/build/linux-s390x-server-release/support/gensrc/java.base/module-info.java' failed
[2021-10-29T13:56:39.348Z] gmake[3]: *** [/home/jenkins/workspace/Build_JDK17_s390x_linux_Personal/build/linux-s390x-server-release/support/gensrc/java.base/module-info.java] Error 1
[2021-10-29T13:56:39.348Z] make/Main.gmk:145: recipe for target 'java.base-gensrc-moduleinfo' failed
[2021-10-29T13:56:39.348Z] gmake[2]: *** [java.base-gensrc-moduleinfo] Error 1
[2021-10-29T13:56:39.348Z] gmake[2]: *** Waiting for unfinished jobs....
...
[2021-10-29T14:10:01.698Z] [100%] Built target j9ddr
[2021-10-29T14:10:01.698Z] [100%] Built target j9ddr
[2021-10-29T14:10:01.698Z] 
[2021-10-29T14:10:01.698Z] ERROR: Build failed for target 'all' in configuration 'linux-s390x-server-release' (exit code 2) 
[2021-10-29T14:10:01.698Z] 
[2021-10-29T14:10:01.698Z] === Make failed targets repeated here ===
[2021-10-29T14:10:01.698Z] common/modules/GensrcModuleInfo.gmk:82: recipe for target '/home/jenkins/workspace/Build_JDK17_s390x_linux_Personal/build/linux-s390x-server-release/support/gensrc/java.base/module-info.java' failed
[2021-10-29T14:10:01.698Z] make/Main.gmk:145: recipe for target 'java.base-gensrc-moduleinfo' failed
[2021-10-29T14:10:01.698Z] === End of repeated output ===

@0xdaryl 0xdaryl self-assigned this Oct 30, 2021
@0xdaryl 0xdaryl merged commit 316bdc3 into eclipse-openj9:master Oct 30, 2021
@a7ehuo a7ehuo deleted the PR-use-classNameToSignature-ClassEnv branch January 12, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants