Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move classNameToSignature to ClassEnv #6217

Closed
0xdaryl opened this issue Oct 25, 2021 · 1 comment
Closed

Move classNameToSignature to ClassEnv #6217

0xdaryl opened this issue Oct 25, 2021 · 1 comment
Assignees
@a7ehuo
Labels
backlog comp:compiler

Comments

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 25, 2021

The function:

omr/compiler/il/Aliases.cpp

Line 1048 in a623525

classNameToSignature(const char *name, int32_t &len, TR::Compilation * comp, TR_AllocationKind allocKind)

is highly project-specific and its current implementation follows Java semantics.

It should be moved into the ClassEnv hierarchy and the existing implementation sunk into the OpenJ9 project. The default OMR implementation could simply return a char string with the given class name.

All calls to classNameToSignature should be re-routed to the version in ClassEnv.
@0xdaryl 0xdaryl mentioned this issue Oct 25, 2021
Open
@a7ehuo a7ehuo self-assigned this Oct 25, 2021
a7ehuo added a commit to a7ehuo/omr that referenced this issue Oct 26, 2021
@a7ehuo
Add classNameToSignature to ClassEnv
f72422f 
This will replace the implementation in Aliases.cpp

Replated to eclipse#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
This was referenced Oct 26, 2021
Merged
Merged
a7ehuo added a commit to a7ehuo/omr that referenced this issue Oct 26, 2021
@a7ehuo
Replace classNameToSignature with the define in ClassEnv
f798dbc 
Replated to eclipse#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
This was referenced Oct 26, 2021
Merged
Merged
a7ehuo added a commit to a7ehuo/omr that referenced this issue Oct 26, 2021
@a7ehuo
Add classNameToSignature to ClassEnv
fee2a64 
This will replace the implementation in Aliases.cpp.
This API adds a new default argument `TR_OpaqueClassBlock *`
to be used to check if the class is a value type or not.

Replated to eclipse#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
Copy link
Contributor

a7ehuo commented Oct 26, 2021

Add new API in ClassEnv

Replace the existing classNameToSignature with the new API

a7ehuo added a commit to a7ehuo/openj9 that referenced this issue Oct 27, 2021
@a7ehuo
Add classNameToSignature to ClassEnv
41b957d 
This will replace the implementation in Aliases.cpp.
This API adds a new default argument `TR_OpaqueClassBlock *`
to be used to check if the class is a value type or not.

Related to eclipse/omr#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo added a commit to a7ehuo/openj9 that referenced this issue Oct 27, 2021
@a7ehuo
Replace classNameToSignature with the define in ClassEnv
6bd31a9 
Related to eclipse/omr#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo added a commit to a7ehuo/omr that referenced this issue Oct 27, 2021
@a7ehuo
Replace classNameToSignature with the define in ClassEnv
11c5bef 
Related to eclipse#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo added a commit to a7ehuo/omr that referenced this issue Oct 27, 2021
@a7ehuo
Add classNameToSignature to ClassEnv
cbf479d 
This will replace the implementation in Aliases.cpp.
This API adds a new default argument `TR_OpaqueClassBlock *`
to be used to check if the class is a value type or not.

Related to eclipse#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo added a commit to a7ehuo/omr that referenced this issue Oct 29, 2021
@a7ehuo
Replace classNameToSignature with the define in ClassEnv
90d0dc0 
Related to eclipse#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
qasimy123 pushed a commit to qasimy123/openj9-jit-debug-agent that referenced this issue Nov 26, 2021
@a7ehuo
Add classNameToSignature to ClassEnv
24327a9 
This will replace the implementation in Aliases.cpp.
This API adds a new default argument `TR_OpaqueClassBlock *`
to be used to check if the class is a value type or not.

Related to eclipse/omr#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
qasimy123 pushed a commit to qasimy123/openj9-jit-debug-agent that referenced this issue Nov 26, 2021
@a7ehuo
Replace classNameToSignature with the define in ClassEnv
358de3b 
Related to eclipse/omr#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a7ehuo a7ehuo

Labels
backlog comp:compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xdaryl @a7ehuo