Guard JITServer version printing #14517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attn @mpirvu |
mpirvu
reviewed
Feb 15, 2022
| TR::PersistentInfo *persistentInfo = compInfo->getPersistentInfo(); | ||
| if (persistentInfo->getRemoteCompilationMode() == JITServer::SERVER || |
There was a problem hiding this comment.
Suggestion: we already have a test for SERVER/CLIENT on line 2339, so it may be better to have the entire body of this method under that if.
There was a problem hiding this comment.
That's possible. Or the printJITServerVersion line could be duplicated in the subsequent two if statements on lines 2374 and 2379, which would avoid an extra checks entirely.
The JITServer version should only be printed in client or server compilation mode, as it is confusing otherwise. This applies even when JITServer verbose mode is enabled. Fixes: eclipse-openj9#14514 Signed-off-by: Christian Despres <despresc@ibm.com>
cjjdespres
force-pushed
the
jitserver-version-print
branch
from
84ac251
to
6e068b9
Compare
mpirvu
approved these changes
Feb 15, 2022
|
jenkins test sanity zlinuxjit jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JITServer version should only be printed in client or server
compilation mode, as it is confusing otherwise. This applies even when
JITServer verbose mode is enabled.
Fixes: #14514
Signed-off-by: Christian Despres despresc@ibm.com