(v0.32.0) Average Copy Forward Rate fix #14790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't calculate average CopyFoward rate (mostly characteristic of h/w expressed in Bytes/microsec units) if no bytes are copied (for example due to abort, all have been subject to Mark-Compact). Otherwise we would incorrectly drag down the averages, potentially to 0, which may later cause problems. We still calculate average amount of bytes that are Copy-Forwarded per PGC, and it's ok to drag down the average if we indeed do all or mostly Mark-Compact work. Signed-off-by: Aleksandar Micic <amicic@ca.ibm.com>
pshipton
approved these changes
Mar 28, 2022
dmitripivkine
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't calculate average CopyFoward rate (mostly characteristic of h/w
expressed in Bytes/microsec units) if no bytes are copied (for example
due to abort, all have been subject to Mark-Compact). Otherwise we would
incorrectly drag down the averages, potentially to 0, which may later
cause problems.
We still calculate average amount of bytes that are Copy-Forwarded per
PGC, and it's ok to drag down the average if we indeed do all or mostly
Mark-Compact work.
Port of #14771 for the 0.32 release.
Signed-off-by: Aleksandar Micic amicic@ca.ibm.com