-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing bounds check to deleteCharAt #15979
Conversation
jenkins test sanity,extended,sanity.openjdk alinux64 jdk8 |
25136a7
to
177ac9c
Compare
|
In this case, I think our doc is wrong, last condition to throw the exception should be |
177ac9c
to
d1d2afc
Compare
Early PR build for reference https://openj9-jenkins.osuosl.org/view/Pull%20Requests/job/PullRequest-OpenJ9/2761/ |
I think the documentation is correct. It might be better written as three |
For StringBuilder and StringBuffer Add tests for deleteCharAt with out of bound indices. Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
d1d2afc
to
dd4d6e7
Compare
Updated the docs for |
jenkins test sanity alinux64 jdk8 |
I'm inclined to include this in the 0.35 release since it fixes a bug / user problem, the fix appears low risk, and we haven't yet done the M2 build for jdk8. @keithc-ca thoughts? |
I agree. |
@mikezhang1234567890 please create a PR against the 0.35 branch. |
For StringBuilder and StringBuffer
Add tests for deleteCharAt with out of bound indices.
Fixes #15897
Tested internally here running JCL_Test_SE80