Jenkins: Always publish buildInfo to Artifactory #16102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins compile amac jdk11 |
AdamBrousseau
force-pushed
the
arty_buildinfo_debug
branch
from
95f08fd
to
ac056ff
Compare
AdamBrousseau
changed the title
|
Leaving this in draft for now as I suspect it will break internal builds due to another ongoing issue I am investigating (infrastructure/7361). |
AdamBrousseau
force-pushed
the
arty_buildinfo_debug
branch
from
ac056ff
to
7eac613
Compare
In the orignal change to add support for multiple Artifactory servers, including servers behind a VPN (eclipse-openj9#8817), I made a note that buildInfo cannot be published to VPN'd servers because while the artifacts are pushed from the node, the buildInfo is pushed from the Controller and therefore would fail to push if the Controller could not see the Artifactory server behind the VPN. Since that change, we've move the UNB VPN connection directly onto our Controller node, this means we can now publish buildInfo to the UNB server. This essentially means that as of today, we can push buildInfo to all servers. Note we still need the Artifactory vpn config info for other parts of the code. Also note that the if condition written prior to this change was incorrect so we actually have never published buildInfo since 8817 went in. Supersedes eclipse-openj9#18203 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
force-pushed
the
arty_buildinfo_debug
branch
from
7eac613
to
85d65e0
Compare
|
Being tested with #16103 |
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
Oct 16, 2023
The internal Artifactory server is forcing us touse a buildName prefix. This adds the option to have a buildName prefix. However, we don't need this at the OpenJ9 Jenkins farm so defaults.yml sets the option to empty string. Should be merged after eclipse-openj9#16102 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
keithc-ca
approved these changes
Oct 16, 2023
pshipton
approved these changes
Oct 16, 2023
midronij
pushed a commit
to midronij/openj9
that referenced
this pull request
Oct 26, 2023
The internal Artifactory server is forcing us touse a buildName prefix. This adds the option to have a buildName prefix. However, we don't need this at the OpenJ9 Jenkins farm so defaults.yml sets the option to empty string. Should be merged after eclipse-openj9#16102 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the orignal change to add support for multiple
Artifactory servers, including servers behind a VPN
(#8817), I made a note that buildInfo cannot be published
to VPN'd servers because while the artifacts are pushed
from the node, the buildInfo is pushed from the Controller
and therefore would fail to push if the Controller could
not see the Artifactory server behind the VPN. Since that
change, we've move the UNB VPN connection directly onto our
Controller node, this means we can now publish buildInfo to
the UNB server. This essentially means that as of today, we
can push buildInfo to all servers.
Note we still need the Artifactory vpn config info for other
parts of the code.
Also note that the if condition written prior to
this change was incorrect so we actually have never published
buildInfo since 8817 went in.
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com