-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GC Regression test for Continuation #16190
base: master
Are you sure you want to change the base?
Conversation
1837af3
to
5ec46ef
Compare
@llxia @fengxue-IS please review the change, Thanks |
byte[] array5120 = new byte[5120]; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline at EOF
var wrapper = new Object(){ boolean executed = false; }; | ||
try { | ||
Thread t = Thread.ofVirtual().name("duke").unstarted(() -> { | ||
wrapper.executed = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing indent.
Also whats the reason for having wrapper/virtualthread duke? seems like it just exits directly after setting wrapper.executed
to true (which isn't used anywhere else).
IntStream.range(0,20 ).forEach(i -> { | ||
executor.submit(() -> { | ||
Random rand = new Random(); | ||
System.out.println("loom thread " + i); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should limit output to errors only?
doesn't make a lot of sense to have large amount of output in test log if the test passes
5ec46ef
to
1b1dffb
Compare
<variation>--enable-preview -Xgcpolicy:optthruput -Xcompactgc</variation> | ||
<variation>--enable-preview -Xgcpolicy:gencon</variation> | ||
<variation>--enable-preview -Xgcpolicy:balanced</variation> | ||
<variation>--enable-preview -Xgcpolicy:optavgpause -Xgc:concurrentMark</variation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concurrentMark is default, not needed
1b1dffb
to
5abefc5
Compare
<types> | ||
<type>native</type> | ||
</types> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this is needed since there isn't any native code required for this test
The tests try to create the cases that continuations are created/mounted /unmounted/terminated before or between GCs(includes during concurrent GC), to verify if there are any regressions for new GC updates. Signed-off-by: Lin Hu <linhu@ca.ibm.com>
5abefc5
to
97309af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run aqa --sdk_resource customized --customized_sdk_url https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK11_x86-64_linux_Nightly/433/OpenJ9-JDK11-x86-64_linux-20221201-010020.tar.gz --build_list functional --target Jep425Tests_testContinuationGC --jdk_version 11 --jdk_impl openj9 --platform x86-64_linux |
@llxia Build(s) started with the following parameters:
Workflow Run ID: 3593198000 |
@llxia Build(s) failed. |
run aqa --sdk_resource customized --customized_sdk_url https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK19_x86-64_linux_Nightly/128/OpenJ9-JDK19-x86-64_linux-20221130-204856.tar.gz --build_list functional --target Jep425Tests_testContinuationGC --jdk_version 19 --jdk_impl openj9 --platform x86-64_linux |
@llxia Build(s) started with the following parameters:
Workflow Run ID: 3593629700 |
@llxia Build(s) successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The tests try to create the cases that continuations are created/mounted /unmounted/terminated before or between GCs(includes during concurrent
GC), to verify if there are any regressions for new GC updates.
Signed-off-by: Lin Hu linhu@ca.ibm.com