Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GC Regression test for Continuation #16190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LinHu2016
Copy link
Contributor

The tests try to create the cases that continuations are created/mounted /unmounted/terminated before or between GCs(includes during concurrent
GC), to verify if there are any regressions for new GC updates.

Signed-off-by: Lin Hu linhu@ca.ibm.com

@LinHu2016 LinHu2016 force-pushed the GC_Loom_test branch 2 times, most recently from 1837af3 to 5ec46ef Compare October 25, 2022 17:35
@LinHu2016
Copy link
Contributor Author

@llxia @fengxue-IS please review the change, Thanks

byte[] array5120 = new byte[5120];
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline at EOF

var wrapper = new Object(){ boolean executed = false; };
try {
Thread t = Thread.ofVirtual().name("duke").unstarted(() -> {
wrapper.executed = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing indent.
Also whats the reason for having wrapper/virtualthread duke? seems like it just exits directly after setting wrapper.executed to true (which isn't used anywhere else).

IntStream.range(0,20 ).forEach(i -> {
executor.submit(() -> {
Random rand = new Random();
System.out.println("loom thread " + i);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should limit output to errors only?
doesn't make a lot of sense to have large amount of output in test log if the test passes

@fengxue-IS fengxue-IS added comp:test project:loom Used to track Project Loom related work labels Oct 25, 2022
<variation>--enable-preview -Xgcpolicy:optthruput -Xcompactgc</variation>
<variation>--enable-preview -Xgcpolicy:gencon</variation>
<variation>--enable-preview -Xgcpolicy:balanced</variation>
<variation>--enable-preview -Xgcpolicy:optavgpause -Xgc:concurrentMark</variation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concurrentMark is default, not needed

Comment on lines 88 to 90
<types>
<type>native</type>
</types>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this is needed since there isn't any native code required for this test

The tests try to create the cases that continuations are created/mounted
/unmounted/terminated before or between GCs(includes during concurrent
 GC), to verify if there are any regressions for new GC updates.

Signed-off-by: Lin Hu <linhu@ca.ibm.com>
Copy link
Contributor

@fengxue-IS fengxue-IS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor

llxia commented Dec 1, 2022

run aqa --sdk_resource customized --customized_sdk_url https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK11_x86-64_linux_Nightly/433/OpenJ9-JDK11-x86-64_linux-20221201-010020.tar.gz --build_list functional --target Jep425Tests_testContinuationGC --jdk_version 11 --jdk_impl openj9 --platform x86-64_linux

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

@llxia Build(s) started with the following parameters:

  • sdk_resource: ['customized']
  • customized_sdk_url: ['https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK11_x86-64_linux_Nightly/433/OpenJ9-JDK11-x86-64_linux-20221201-010020.tar.gz']
  • archive_extension: ['.tar']
  • build_list: ['functional']
  • target: ['_Jep425Tests_testContinuationGC']
  • platform: ['ubuntu-latest']
  • jdk_version: ['11']
  • jdk_impl: ['openj9']
  • openjdk_testrepo: ['adoptium/aqa-tests:master']
  • tkg_repo: ['adoptium/TKG:master']

Workflow Run ID: 3593198000

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

@llxia Build(s) failed.
Workflow Run ID: 3593198000

@llxia
Copy link
Contributor

llxia commented Dec 1, 2022

run aqa --sdk_resource customized --customized_sdk_url https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK19_x86-64_linux_Nightly/128/OpenJ9-JDK19-x86-64_linux-20221130-204856.tar.gz --build_list functional --target Jep425Tests_testContinuationGC --jdk_version 19 --jdk_impl openj9 --platform x86-64_linux

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

@llxia Build(s) started with the following parameters:

  • sdk_resource: ['customized']
  • customized_sdk_url: ['https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK19_x86-64_linux_Nightly/128/OpenJ9-JDK19-x86-64_linux-20221130-204856.tar.gz']
  • archive_extension: ['.tar']
  • build_list: ['functional']
  • target: ['_Jep425Tests_testContinuationGC']
  • platform: ['ubuntu-latest']
  • jdk_version: ['19']
  • jdk_impl: ['openj9']
  • openjdk_testrepo: ['adoptium/aqa-tests:master']
  • tkg_repo: ['adoptium/TKG:master']

Workflow Run ID: 3593629700

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

@llxia Build(s) successful.
Workflow Run ID: 3593629700

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:test project:loom Used to track Project Loom related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants