Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update criu test to ignore tid issues #16373

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Update criu test to ignore tid issues #16373

merged 1 commit into from
Nov 30, 2022

Conversation

tajila
Copy link
Contributor

@tajila tajila commented Nov 28, 2022

Update criu test to ignore tid issues

If CRIU can't acquire the origin thread IDs it will fail, nothing can be done about this. update tests to ignore this failure. Long term we may need to transform all tests to container tests.

Signed-off-by: Tobi Ajila atobia@ca.ibm.com

@tajila
Copy link
Contributor Author

tajila commented Nov 28, 2022

Jenkins test sanity xlinuxcriu jdk17

@tajila
Copy link
Contributor Author

tajila commented Nov 28, 2022

200x grinder - https://openj9-jenkins.osuosl.org/job/Grinder/1531/

@tajila
Copy link
Contributor Author

tajila commented Nov 29, 2022 •
edited

@llxia I found the following issue in the grinder https://openj9-jenkins.osuosl.org/job/Grinder_testList_1/80/tapResults/

Output from test:
 [ERR] bash: /home/jenkins/workspace/Grinder_testList_1/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/criu/criuScript.sh: No such file or directory

Have you seen this before?

@tajila tajila requested a review from babsingh November 29, 2022 15:43
@tajila
Copy link
Contributor Author

tajila commented Nov 29, 2022

@babsingh please review

@llxia
Copy link
Contributor

llxia commented Nov 29, 2022

re #16373 (comment), no, I haven't seen this before. Please let us know if this occurs again. Thanks

@tajila
Copy link
Contributor Author

tajila commented Nov 29, 2022

Jenkins test sanity xlinuxcriu jdk17

babsingh
babsingh requested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than minor formatting suggestions for the comment.

test/functional/cmdLineTests/criu/criu.xml Outdated Show resolved Hide resolved
test/functional/cmdLineTests/criu/criu_keepCheckpoint.xml Outdated Show resolved Hide resolved
@tajila
Copy link
Contributor Author

tajila commented Nov 29, 2022

Existing PR test, https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK17_x86-64_linux_criu/152/

@tajila
Copy link
Contributor Author

tajila commented Nov 29, 2022

Changes are ready for another look

@tajila
Update criu test to ignore tid issues
7e6cf28 
If CRIU can't acquire the origin thread IDs it will fail, nothing can be
done about this. update tests to ignore this failure. Long term we may
need to transform all tests to container tests.

Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
@JasonFengJ9 JasonFengJ9 mentioned this pull request Nov 29, 2022
Closed
babsingh
babsingh approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @llxia Do the changes look good to you?

llxia
llxia approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@babsingh
Copy link
Contributor

Jenkins test sanity xlinuxcriu jdk17

@babsingh
Copy link
Contributor

babsingh commented Nov 30, 2022 •
edited

https://openj9-jenkins.osuosl.org/job/Test_openjdk17_j9_sanity.functional_x86-64_linux_criu_Personal/38/tapResults/

Noticed the same failures, which were reported in #16376 (comment).

FAILED: test_isAnnotationPresent
java.lang.AssertionError: Following exception occured : Cannot invoke "java.io.File.deleteOnExit()" because "folder" is null
	at org.testng.Assert.fail(Assert.java:96) from jdk.internal.loader.ClassLoaders$AppClassLoader@43abce9b(file:/home/jenkins/workspace/Test_openjdk19_j9_sanity.functional_s390x_linux_Personal_testList_1/aqa-tests/TKG/lib/testng.jar)
	at org.openj9.test.annotationPackage.Test_PackageAnnotation2.test_isAnnotationPresent(Test_PackageAnnotation2.java:52) from jdk.internal.loader.ClassLoaders$AppClassLoader@43abce9b(file:/home/jenkins/workspace/Test_openjdk19_j9_sanity.functional_s390x_linux_Personal_testList_1/jvmtest/functional/Java8andUp/GeneralTest.jar)
...

FAILED: test_fileHasOtherAccess
java.lang.AssertionError: null
	at org.testng.Assert.fail(Assert.java:96)
	at org.testng.Assert.fail(Assert.java:103)
	at org.openj9.test.jdk.internal.agent.Test_FileSystem_Base.testSetup(Test_FileSystem_Base.java:47)
...

The above issue was fixed; see #16376 (comment).

@babsingh
Copy link
Contributor

Jenkins test sanity xlinuxcriu jdk17

@babsingh babsingh merged commit cc152a4 into eclipse-openj9:master Nov 30, 2022
@tajila tajila mentioned this pull request Nov 30, 2022
Merged
@VermaSh VermaSh mentioned this pull request Jan 13, 2023
Merged
VermaSh added a commit to VermaSh/openj9 that referenced this pull request Jan 13, 2023
@VermaSh
Update criu_random test to ignore tid issues
f1f92c6 
Related PR: eclipse-openj9#16373

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tajila @llxia @babsingh