Fix jvmtiGetThreadInfo to return correct thread group

[dipak-bagadiya]

The jvmtiGetThreadInfo returns the invalid thread group in case of unstarted threads. A NULL targetThread indicates that the thread is either unstarted or terminated so this check is not sufficient to validate terminated threads.

The boolean check is updated in jvmtiGetThreadInfo to return a valid thread group for unstarted threads.

Fixes: #16226

Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com

[dipak-bagadiya]

@babsingh and @fengxue-IS Please review PR

[fengxue-IS]

lgtm

[babsingh]

https://openj9-jenkins.osuosl.org/job/PullRequest-LineEndingsCheck-OpenJ9/7285/console

@dipak-bagadiya The line endings check is failing.

13:36:06  runtime/jvmti/jvmtiThread.c:529: space before tab in indent.
13:36:06  + 					 * As per the JVMTI spec, the thread group should be NULL IFF the thread is terminated.
13:36:06  runtime/jvmti/jvmtiThread.c:530: space before tab in indent.
13:36:06  + 					 */

[fengxue-IS]

lgtm

[babsingh]

jenkins test sanity zlinux jdk19

[babsingh]

jenkins compile win jdk8

[babsingh]

@dipak-bagadiya After this PR is merged, we can re-enable the test. The following exclude lines need to be removed:

• JDK19: https://github.com/adoptium/aqa-tests/blob/cabd0e33d0662d009171f10fd33eb3b4f50115e4/openjdk/excludes/ProblemList_openjdk19-openj9.txt#L595
• JDK20: https://github.com/adoptium/aqa-tests/blob/d295e74a930c04d59404650475d4c1cf31107807/openjdk/excludes/ProblemList_openjdk20-openj9.txt#L636

Also, the test excluded label will need to be removed in #16226.

@fengxue-IS I will be on vacation for the remainder of the week. Please assist Dipak if there are any doubts.

[babsingh]

jenkins test sanity amac jdk19

[babsingh]

https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_sanity.functional_s390x_linux_Personal/47/tapResults/

@pshipton @JasonFengJ9 @AdamBrousseau Are the below file system failures related to an infra issue?

FAILED: test_isAnnotationPresent
java.lang.AssertionError: Following exception occured : Cannot invoke "java.io.File.deleteOnExit()" because "folder" is null
	at org.testng.Assert.fail(Assert.java:96) from jdk.internal.loader.ClassLoaders$AppClassLoader@43abce9b(file:/home/jenkins/workspace/Test_openjdk19_j9_sanity.functional_s390x_linux_Personal_testList_1/aqa-tests/TKG/lib/testng.jar)
	at org.openj9.test.annotationPackage.Test_PackageAnnotation2.test_isAnnotationPresent(Test_PackageAnnotation2.java:52) from jdk.internal.loader.ClassLoaders$AppClassLoader@43abce9b(file:/home/jenkins/workspace/Test_openjdk19_j9_sanity.functional_s390x_linux_Personal_testList_1/jvmtest/functional/Java8andUp/GeneralTest.jar)
...

FAILED: test_fileHasOtherAccess
java.lang.AssertionError: null
	at org.testng.Assert.fail(Assert.java:96)
	at org.testng.Assert.fail(Assert.java:103)
	at org.openj9.test.jdk.internal.agent.Test_FileSystem_Base.testSetup(Test_FileSystem_Base.java:47)
...

[babsingh]

jenkins test sanity xlinux jdk19

[AdamBrousseau]

Unless that test cares about cleaning up the files, I would assume an infra issue. Folder is cleanup up on disk now.

[JasonFengJ9]

[TargetManager] [ERROR] could not load or use openj9.internal.tools.attach.target.AttachHandler

This looks like a machine/setup issue.

[JasonFengJ9]

FAILED: test_getResources
java.lang.NullPointerException: Cannot invoke "java.io.File.deleteOnExit()" because "folder" is null
at org.openj9.test.support.resource.Support_Resources.createTempFolder(Support_Resources.java:85) from

java.io.IOException: Not a directory
at java.base/java.io.UnixFileSystem.createFileExclusively(UnixFileSystem.java:356) from jrt:/java.base
at java.base/java.io.File.createTempFile(File.java:2179) from jrt:/java.base
at java.base/java.io.File.createTempFile(File.java:2225) from jrt:/java.base
at org.testng.reporters.FileStringBuffer.flushToFile(FileStringBuffer.java:105) from

There are quite a few errors in sanity.funtional, wondering if it is related to adoptium/TKG#378 which has been reverted.
@babsingh I suggest another PR build.

[babsingh]

jenkins test sanity zlinux jdk19