Restrict presubmit.yml permissions, delete assign-to-project.yml #16699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanHeidinga can you pls take a look. @AdamBrousseau @llxia fyi |
DanHeidinga
reviewed
Feb 13, 2023
There was a problem hiding this comment.
The presubmit.yml looks good.
I'd actually be tempted to delete the assign-to-project.yml action as it's no longer required. Now that triage teams are able to assign items [0], regular contributors don't have to rely on magic labels to get things assigned correctly.
[0] #9180 (comment)
No concerns with this |
|
No objections on deleting |
https://github.com/ossf/scorecard/blob/c61f6bc297ee71dc4b5f2511144d6c031b946089/docs/checks.md#token-permissions As determined by https://github.com/ossf/scorecard#scorecard-command-line-interface Delete assign-to-project.yml since it's no longer needed. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
force-pushed
the
actionperms
branch
from
e417e54
to
c11e2e9
Compare
pshipton
changed the title
DanHeidinga
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ossf/scorecard/blob/c61f6bc297ee71dc4b5f2511144d6c031b946089/docs/checks.md#token-permissions
As determined by https://github.com/ossf/scorecard#scorecard-command-line-interface
https://app.stepsecurity.io/secureworkflow/eclipse-openj9/openj9/presubmit.yml/master?enable=permissions
Delete assign-to-project.yml since it's no longer needed.