Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Remove inappropriate static keywords from variables #18007

Merged

Conversation

Akira1Saitoh
Copy link
Contributor

JITServer communicates with clients and retrieves certain values, like objectAlignmentInBytes, to maintain consistent values for each client. In this context, these per-client values can't be treated as constants, and any static keywords on variables should be removed if those values are being assigned.

JITServer communicates with clients and retrieves certain values,
like `objectAlignmentInBytes`, to maintain consistent values for each client.
In this context, these per-client values can't be treated as constants,
and any `static` keywords on variables should be removed
if those values are being assigned.

Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
@knn-k
Copy link
Contributor

knn-k commented Aug 24, 2023

Jenkins test sanity.functional alinux64jit jdk8,jdk11,jdk17

@knn-k knn-k mentioned this pull request Aug 24, 2023
12 tasks
@knn-k
Copy link
Contributor

knn-k commented Aug 24, 2023

@0xdaryl FYI.

@knn-k knn-k self-assigned this Aug 25, 2023
@knn-k knn-k merged commit 659cb99 into eclipse-openj9:master Aug 25, 2023
9 checks passed
@knn-k
Copy link
Contributor

knn-k commented Aug 25, 2023

jit_jitt_array_compress_3 test finished successfully in the jobs for JDK 8/11/17.

@Akira1Saitoh Akira1Saitoh deleted the AArch64JitserverRemoveStatic branch August 25, 2023 00:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants