Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFI/Jreg_JDK21] Fix the issue with the nested struct in libffi #18375

Conversation

ChengJin01
Copy link
Contributor

@ChengJin01 ChengJin01 commented Oct 30, 2023

The change simply adopts the fix at libffi/libffi#805
to resolve the the issue with the nested struct in libffi on AIX.

Related: #18287

Note:
The changes should be kept in sync with the code at libffi/libffi#805
if any update.

Signed-off-by: ChengJin01 jincheng@ca.ibm.com

@ChengJin01 ChengJin01 added comp:vm project:panama Used to track Project Panama related work jdk21 labels Oct 30, 2023
@ChengJin01
Copy link
Contributor Author

Reviewer: @pshipton
FYI: @tajila, @gacholio

@pshipton
Copy link
Member

Are you wanting to merge this before libffi/libffi#805 is merged?

@ChengJin01
Copy link
Contributor Author

ChengJin01 commented Oct 31, 2023

Are you wanting to merge this before libffi/libffi#805 is merged?

We are not sure how long it takes for the libffi PR to be merged as nobody out there is assigned to review the code for now.

@tajila, any input on this?

@ChengJin01 ChengJin01 force-pushed the fix_jtreg_libffi_aix_nested_struct_jdk21_v1 branch from 44efc9b to d29d3f8 Compare October 31, 2023 03:01
@ChengJin01
Copy link
Contributor Author

libffi/libffi#805 is currently under the code review. We will sync with the latest update to see whether it can be merged very soon.

@keithc-ca
Copy link
Contributor

We should either address https://github.com/libffi/libffi/pull/805/files#r1377953612 or launch test compiles to see if the compilers we're using tolerate that non-C code.

@ChengJin01
Copy link
Contributor Author

ChengJin01 commented Oct 31, 2023

We should either address https://github.com/libffi/libffi/pull/805/files#r1377953612 or launch test compiles to see if the compilers we're using tolerate that non-C code.

We can wait for libffi/libffi#805 (still under code review) to sync with the latest update given this is literally not our code in OpenJ9.

@pshipton
Copy link
Member

pshipton commented Nov 1, 2023

jenkins compile aix jdk8

@pshipton
Copy link
Member

pshipton commented Nov 1, 2023

jenkins compile plinux jdk8,jdk17

@ChengJin01 ChengJin01 force-pushed the fix_jtreg_libffi_aix_nested_struct_jdk21_v1 branch from d29d3f8 to e75760c Compare November 13, 2023 19:57
@ChengJin01
Copy link
Contributor Author

ChengJin01 commented Nov 13, 2023

I just updated the PR with the latest code changes in libffi/libffi#805. So we are able to verify & merge this as soon as possible and refresh it later if any more updates in libffi/libffi#805 (which is likely to be postponed to the end of this month as the developer working on this PR is away for two weeks).

@pshipton
Copy link
Member

jenkins test sanity.openjdk aix,plinux jdk11,jdk17,jdk21

@pshipton
Copy link
Member

Pls fix the commit message to remove "Fixes" so we don't close the issue, and update the date in libffi/about.html

For reference the running PR build is https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4745/

@ChengJin01
Copy link
Contributor Author

Pls fix the commit message to remove "Fixes" so we don't close the issue, and update the date in libffi/about.html

Replaced with "Related".

The change simply adopts the fix at libffi/libffi#805
to resolve the the issue with the nested struct in libffi on AIX.

Related: eclipse-openj9#18287

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
@ChengJin01 ChengJin01 force-pushed the fix_jtreg_libffi_aix_nested_struct_jdk21_v1 branch from e75760c to d20515b Compare November 13, 2023 20:53
@pshipton pshipton merged commit df46709 into eclipse-openj9:master Nov 14, 2023
2 checks passed
ChengJin01 added a commit to ChengJin01/aqa-tests that referenced this pull request Nov 14, 2023
The changes enable the FFI test suite in JDK21+
given the issue with struct on AIX was resolved
via eclipse-openj9/openj9#18375.

Fixes: #eclipse-openj9/openj9/issues/17674

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
llxia pushed a commit to adoptium/aqa-tests that referenced this pull request Nov 15, 2023
The changes enable the FFI test suite in JDK21+
given the issue with struct on AIX was resolved
via eclipse-openj9/openj9#18375.

Fixes: #eclipse-openj9/openj9/issues/17674

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
llxia pushed a commit to llxia/openjdk-tests that referenced this pull request Nov 22, 2023
The changes enable the FFI test suite in JDK21+
given the issue with struct on AIX was resolved
via eclipse-openj9/openj9#18375.

Fixes: #eclipse-openj9/openj9/issues/17674

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
llxia pushed a commit to llxia/openjdk-tests that referenced this pull request Nov 22, 2023
The changes enable the FFI test suite in JDK21+
given the issue with struct on AIX was resolved
via eclipse-openj9/openj9#18375.

Fixes: #eclipse-openj9/openj9/issues/17674

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
pshipton pushed a commit to adoptium/aqa-tests that referenced this pull request Nov 22, 2023
The changes enable the FFI test suite in JDK21+
given the issue with struct on AIX was resolved
via eclipse-openj9/openj9#18375.

Fixes: #eclipse-openj9/openj9/issues/17674

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm jdk21 project:panama Used to track Project Panama related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants