-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FFI/Jreg_JDK21] Fix the issue with the nested struct in libffi #18375
[FFI/Jreg_JDK21] Fix the issue with the nested struct in libffi #18375
Conversation
Are you wanting to merge this before libffi/libffi#805 is merged? |
We are not sure how long it takes for the libffi PR to be merged as nobody out there is assigned to review the code for now. @tajila, any input on this? |
44efc9b
to
d29d3f8
Compare
I updated the date to 2023 but still kept the version to |
libffi/libffi#805 is currently under the code review. We will sync with the latest update to see whether it can be merged very soon. |
We should either address https://github.com/libffi/libffi/pull/805/files#r1377953612 or launch test compiles to see if the compilers we're using tolerate that non-C code. |
We can wait for libffi/libffi#805 (still under code review) to sync with the latest update given this is literally not our code in OpenJ9. |
jenkins compile aix jdk8 |
jenkins compile plinux jdk8,jdk17 |
d29d3f8
to
e75760c
Compare
I just updated the PR with the latest code changes in libffi/libffi#805. So we are able to verify & merge this as soon as possible and refresh it later if any more updates in libffi/libffi#805 (which is likely to be postponed to the end of this month as the developer working on this PR is away for two weeks). |
jenkins test sanity.openjdk aix,plinux jdk11,jdk17,jdk21 |
Pls fix the commit message to remove "Fixes" so we don't close the issue, and update the date in libffi/about.html For reference the running PR build is https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4745/ |
Replaced with "Related". |
The change simply adopts the fix at libffi/libffi#805 to resolve the the issue with the nested struct in libffi on AIX. Related: eclipse-openj9#18287 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
e75760c
to
d20515b
Compare
The changes enable the FFI test suite in JDK21+ given the issue with struct on AIX was resolved via eclipse-openj9/openj9#18375. Fixes: #eclipse-openj9/openj9/issues/17674 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
The changes enable the FFI test suite in JDK21+ given the issue with struct on AIX was resolved via eclipse-openj9/openj9#18375. Fixes: #eclipse-openj9/openj9/issues/17674 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
The changes enable the FFI test suite in JDK21+ given the issue with struct on AIX was resolved via eclipse-openj9/openj9#18375. Fixes: #eclipse-openj9/openj9/issues/17674 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
The changes enable the FFI test suite in JDK21+ given the issue with struct on AIX was resolved via eclipse-openj9/openj9#18375. Fixes: #eclipse-openj9/openj9/issues/17674 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
The changes enable the FFI test suite in JDK21+ given the issue with struct on AIX was resolved via eclipse-openj9/openj9#18375. Fixes: #eclipse-openj9/openj9/issues/17674 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
The change simply adopts the fix at libffi/libffi#805
to resolve the the issue with the nested struct in libffi on AIX.
Related: #18287
Note:
The changes should be kept in sync with the code at libffi/libffi#805
if any update.
Signed-off-by: ChengJin01 jincheng@ca.ibm.com