-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly link omrsig and enable OMRPORT_OMRSIG_SUPPORT globally #2631
Merged
pshipton
merged 5 commits into
eclipse-openj9:master
from
babsingh:define_sig_support_globally_final
Sep 14, 2018
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cfe191c
Properly link omrsig when building constgen and j9ddrgen
babsingh 11c7267
Remove OMRPORT_OMRSIG_SUPPORT definitions
babsingh 45135e8
Enable OMRPORT_OMRSIG_SUPPORT globally in OpenJ9
babsingh 2311b33
Fix indentation in hyvm/module.xml
babsingh 31f655c
Link omrsig to port and vm only if J9VM_PORT_OMRSIG_SUPPORT is enabled
babsingh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this enable OMRPORT_OMRSIG_SUPPORT in OpenJ9 code? i.e. where does the flag get defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the flag will be defined in
omrcfg.h
.