Don't pass params directly to downstream jobs #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vsebe for review |
- Using params.PARAM will allow null to be passed to a downstream job. This causes a failure if the downstream job has the parameter configured. - Null value not allowed as an environment variable - Adding a check and setting the variable to blank should resolve this failure [skip ci] Issue eclipse-openj9#2138 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
force-pushed
the
dont_pass_null_params
branch
from
aff572e
to
41fb512
Compare
vsebe
approved these changes
Sep 11, 2018
|
@llxia for final review |
llxia
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to a downstream job. This causes a failure if the
downstream job has the parameter configured.
should resolve this failure
[skip ci]
Issue #2138
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com