Use reflection to access attach API internal APIs #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test all plinux all |
|
Jenkins test sanity xlinux jdk11 |
|
This needs more work: |
pdbain-ibm
changed the title
|
Fixed and re-tested. @llxia would you kindly run sanity and extended builds on whichever platform is convenient? |
llxia
reviewed
Sep 24, 2018
| org.eclipse.jdt.core.compiler.debug.sourceFile=generate | ||
| org.eclipse.jdt.core.compiler.problem.assertIdentifier=error | ||
| org.eclipse.jdt.core.compiler.problem.enumIdentifier=error | ||
| org.eclipse.jdt.core.compiler.source=1.8 |
There was a problem hiding this comment.
Do we need to check in this file?
There was a problem hiding this comment.
No. I included that by accident and have removed it.
Could we add .settings and other auto-generated files to the .gitignore file?
Remove unnecessary compiler options related to exposing the APIs. Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
pdbain-ibm
changed the title
|
Jenkins test all plinux all |
|
Jenkins test sanity win jdk11 |
|
windows failure is a known issue: #2955 |
llxia
approved these changes
Sep 25, 2018
pdbain-ibm
added a commit
to pdbain-ibm/openj9
that referenced
this pull request
Feb 8, 2019
Add methods to check for attach API initialization, get process ID, and get virtual machine ID. Use reflection to avoid compile-time dependency in test code on OpenJ9 internal classes Replace some existing references to AttachHandler in favour of the new methods. This is further to "Use reflection to access attach API internal APIs" eclipse-openj9#2962. This allows tests to remove references to attach API implementation classes and compile without requiring `--add-exports java.base/com.ibm.tools.attach.target`. This is preparation for tests of new features in eclipse-openj9#4655. [ci skip] Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary compiler options related to exposing the APIs.
Fixes
#2938.
@llxia I ran a personal build with sanity tests on Java 10. Would you kindly start builds to cover extended and Java 8. Thank you.
Signed-off-by: Peter Bain peter_bain@ca.ibm.com