Fix RPATH and dylib install_name on OSX #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi - @DanHeidinga |
|
Related to #36. |
DanHeidinga
reviewed
Sep 27, 2018
| @@ -47,7 +47,7 @@ $(UMA_EXETARGET): $(UMA_OBJECTS) $(UMA_TARGET_LIBRARIES) | |||
| UMA_BEGIN_DASH_L = | |||
| UMA_END_DASH_L = | |||
|
|
|||
| UMA_EXE_POSTFIX_FLAGS += -lm -liconv -lc -ldl -lutil -Wl,-rpath,\$$ORIGIN | |||
| UMA_EXE_POSTFIX_FLAGS += -lm -liconv -lc -ldl -lutil -Wl,-rpath,@loader_path/. | |||
There was a problem hiding this comment.
Why /. on the end of the path?
There was a problem hiding this comment.
i think it should work without /.. I will verify and remove it.
There was a problem hiding this comment.
verified; works without /.; removed it.
On OSX, -rpath,\$$ORIGIN doesn't work. -rpath needs to correspond to either @executable_path, @loader_path or some other path. More information can be seen in the man pages of dyld. I have chosen to set rpath as "-rpath,@loader_path/.". @loader_path points to the directory where dylib being loaded exists. This works since libjvm is able to load all the dependent dylibs. When naming dylibs, @rpath/ should be appended to dylib names. Example: @rpath/libj9thr29.dylib. Appending @rpath to the dylib name instructs the dynamic linker to search the list of run paths for the dylib. Reference: https://wincent.com/wiki/%40executable_path%2C_%40load_path_and_%40rpath Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
fix_rpath_osx
branch
from
ec28b2a
to
92f40d1
Compare
|
File is osx only which isn't in the builds yet. Merging as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OSX, -rpath,\$$ORIGIN doesn't work. -rpath needs to correspond to
either @executable_path, @loader_path or some other path. More
information can be seen in the man pages of dyld. I have chosen to set
rpath as "-rpath,@loader_path/.". @loader_path points to the directory
where dylib being loaded exists. This works since libjvm is able to load
all the dependent dylibs.
When naming dylibs, @rpath/ should be appended to dylib names. Example:
@rpath/libj9thr29.dylib. Appending @rpath to the dylib name instructs
the dynamic linker to search the list of run paths for the dylib.
Reference:
https://wincent.com/wiki/%40executable_path%2C_%40load_path_and_%40rpath
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com