Track and check types for SVM symbol IDs #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to ensure that if types are mismatched due to a bug, we will no longer blindly cast and access memory through a pointer to an unrelated type, which is undefined behaviour. Signed-off-by: Devin Papineau <devinmp@ca.ibm.com>
28 tasks
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
|
The test failures are due to #4135 |
|
Sanity looks good - failures look like #4135 as noted - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to ensure that if types are mismatched due to a bug, we will no longer blindly cast and access memory through a pointer to an unrelated type, which is undefined behaviour.