Fix compile error #4213
Merged
Fix compile error #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test sanity win,xLinux jdk11 |
|
similar errors in mminit.cpp - appended the fix. |
|
Jenkins test sanity win,xLinux jdk11 |
Caused by eclipse-openj9#4168 20:51:30 mmparseXXgc.cpp(950) : error C2220: warning treated as error - no 'object' file generated 20:51:30 mmparseXXgc.cpp(950) : warning C4244: '=' : conversion from 'double' to 'float', possible loss of data 20:51:30 mmparseXXgc.cpp(964) : warning C4244: '=' : conversion from 'double' to 'float', possible loss of data Signed-off-by: Aleksandar Micic <amicic@ca.ibm.com>
|
Jenkins test sanity win,xLinux jdk11 |
|
I don't think we need to wait for all the testing to complete. I want to get this merged before the overnight builds start. The builds passed, and the initial testing is also passing. https://ci.eclipse.org/openj9/job/PullRequest-Sanity-JDK11-linux_x86-64_cmprssptrs-OpenJ9/286/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #4168
20:51:30 mmparseXXgc.cpp(950) : error C2220: warning treated as error -
no 'object' file generated
20:51:30 mmparseXXgc.cpp(950) : warning C4244: '=' : conversion from
'double' to 'float', possible loss of data
20:51:30 mmparseXXgc.cpp(964) : warning C4244: '=' : conversion from
'double' to 'float', possible loss of data
Signed-off-by: Aleksandar Micic amicic@ca.ibm.com