WIP Optimize j9shr_storeGCHints() to avoid storing unchanged data #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity zlinux jdk11 |
Related to eclipse-openj9#4168 and eclipse-openj9#3743 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
The zlinux testing passed. Rebasing to pick up the Windows compile fix #4213 so Windows can be tested. |
|
jenkins test sanity win jdk11 |
|
@keithc-ca can you please take a look |
keithc-ca
reviewed
Jan 9, 2019
| vm->sharedClassConfig->localStartupHints.hintsData.heapSize1 = heapSize1; | ||
| vm->sharedClassConfig->localStartupHints.hintsData.heapSize2 = heapSize2; | ||
| vm->sharedClassConfig->localStartupHints.hintsData.flags |= J9SHR_STARTUPHINTS_HEAPSIZES_SET; | ||
| if (!heapSizesSet || (forceReplace && ((heapSize1 != hintsData->heapSize1) || (heapSize2 != hintsData->heapSize2)))) { |
There was a problem hiding this comment.
This changes the meaning of the parameter forceReplace: the name should be changed to match the new behavior (here and where this function and pointers to it are declared).
pshipton
changed the title
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4168 and #3743
Signed-off-by: Peter Shipton Peter_Shipton@ca.ibm.com