Make PassThrough x86 NULLCHKs implicit #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a NULLCHK with a PassThrough will evaluate into test and branch sequences. This change switches the sequence to simplify touch the memory of the value being NULLCHK'd. A trap will result in the appropriate null pointer exception and saves a branch at the cost of some cache pollution. Signed-off-by: Andrew Craik <ajcraik@ca.ibm.com>
|
Jenkins test sanity xlinux,win jdk8,jdk11 |
|
Linux failed due to infrastructure. Relaunching. Jenkins test sanity xlinux jdk8 |
|
@0xdaryl could you review the x codegen change for me? Ordinarily I do the x reviews, but approving my own work is not something I want to do... |
0xdaryl
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a NULLCHK with a PassThrough will evaluate into test and
branch sequences. This change switches the sequence to simply touch
the memory of the value being NULLCHK'd. A trap will result in the
appropriate null pointer exception and saves a branch at the cost of
some potential cache pollution.
Signed-off-by: Andrew Craik ajcraik@ca.ibm.com