Dynamically load libssl in JITServer #8145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
force-pushed
the
dynamicallyLoadOpenSSL
branch
3 times, most recently
from
d962f2d
to
fa8a0ef
Compare
mpirvu
reviewed
Dec 19, 2019
a7ehuo
force-pushed
the
dynamicallyLoadOpenSSL
branch
6 times, most recently
from
aae0fe3
to
7caee01
Compare
|
7caee01 has replaced all the symbols. So far tested the following configuration with OpenSSL connection established between the server and the client.
|
mpirvu
reviewed
Dec 22, 2019
a7ehuo
force-pushed
the
dynamicallyLoadOpenSSL
branch
from
7caee01
to
db29620
Compare
a7ehuo
changed the title
|
@mpirvu All comments addressed. Ready for another review. Thanks! |
mpirvu
approved these changes
Dec 23, 2019
|
Jenkins test sanity xlinuxjit jdk8 |
Dynamically load the OpenSSL libssl symbols required by JITServer. Replaced all the libssl APIs with function calls to the loaded symbols during the runtime. Related to eclipse-openj9#8138 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
dynamicallyLoadOpenSSL
branch
from
db29620
to
cb2f9a7
Compare
|
@mpirvu All comments addressed. Ready for another review. Thanks. All the above three cases are tested with SSL connection established between the client and the server by running Here are more detailed logs from building with 1.0.2 and running with 1.1.1. |
|
Jenkins test sanity xlinuxjit jdk8 |
|
Jenkins test sanity xlinuxjit jdk11 |
|
Jenkins test sanity plinuxjit jdk8,jdk11 |
|
PPC linux build and test failed. Looks like related to protobuf. Doesn’t seem related to this change since the failure exists before OpenSSL is fully enabled in JITServer: https://ci.eclipse.org/openj9/job/Build_JDK8_ppc64le_linux_jit_Personal/2/console Java 8 test failed for both xlinux and ppc linux. Similar to #8153 (comment) |
|
Many Java11 tests fail with: which demangled is An internet search that sometimes people encounter |
|
To recap: Based on the above I think this PR is good to be merged. It will solve a major problem in testing with JITServer. |
a7ehuo
added a commit
to a7ehuo/openj9-openjdk-jdk8
that referenced
this pull request
Dec 31, 2019
With the change in eclipse-openj9/openj9#8145, OpenSSL symbols are dynamically loaded at the runtime. During the build time, there is no longer a dependency on the installed OpenSSL version on the build machines. Removed the code that checks `SSL_CTX_set_ecdh_auto` during config. Signed-off-by: a7ehuo <Annabelle.Huo@ibm.com>
a7ehuo
added a commit
to a7ehuo/openj9-openjdk-jdk13
that referenced
this pull request
Jan 6, 2020
With the change in eclipse-openj9/openj9#8145, `OpenSSL` symbols are dynamically loaded at the runtime. During the build time, there is no longer a dependency on the installed `OpenSSL` version on the build machines. Removed the code that checks `SSL_CTX_set_ecdh_auto` during config. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
added a commit
to a7ehuo/openj9-openjdk-jdk13
that referenced
this pull request
Jan 6, 2020
With the change in eclipse-openj9/openj9#8145, `OpenSSL` symbols are dynamically loaded at the runtime. During the build time, there is no longer a dependency on the installed `OpenSSL` version on the build machines. Removed the code that checks `SSL_CTX_set_ecdh_auto` during config. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
added a commit
to a7ehuo/openj9-openjdk-jdk
that referenced
this pull request
Jan 6, 2020
With the change in eclipse-openj9/openj9#8145, `OpenSSL` symbols are dynamically loaded at the runtime. During the build time, there is no longer a dependency on the installed `OpenSSL` version on the build machines. Removed the code that checks `SSL_CTX_set_ecdh_auto` during config. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
added a commit
to a7ehuo/openj9-openjdk-jdk11
that referenced
this pull request
Jan 6, 2020
With the change in eclipse-openj9/openj9#8145, `OpenSSL` symbols are dynamically loaded at the runtime. During the build time, there is no longer a dependency on the installed `OpenSSL` version on the build machines. Removed the code that checks `SSL_CTX_set_ecdh_auto` during config. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
added a commit
to a7ehuo/openj9-openjdk-jdk14
that referenced
this pull request
Jan 6, 2020
With the change in eclipse-openj9/openj9#8145, `OpenSSL` symbols are dynamically loaded at the runtime. During the build time, there is no longer a dependency on the installed `OpenSSL` version on the build machines. Removed the code that checks `SSL_CTX_set_ecdh_auto` during config. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
This is the same failure I was seeing when doing the installations on our internal machines. Here are the steps I used for the internal P machines: However, this issue looks identical to a problem I saw on s390 machines. Here are the s390 instructions for installing protobuf on the machines that saw this problem: I think something similar can be done for Power as well. @jdekonin Do you recall if this second process was used (particularly the |
|
@dchopra001 I don't recall but the history on the machines tells the story. I can see the remove step was not performed on all of the plinux machines, but only the 6 from UNB actually had that dev package installed. I redid the protobuf install on all the plinux machines. Please retry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically load
libsslin JITServer usingdlopenand load the OpenSSL libssl symbols required by JITServer. Replaced all the libssl APIs with function calls to the loaded symbols during the runtime.Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com