Implement setParameterLinkageRegisterIndex pure virtual function #8413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on eclipse/omr#4776. Leaving this as WIP until that change has been merged. @pshipton FYI this is the fix for the OMR acceptance build failure on Friday. |
This pure virtual function as introduced in OMR to ensure all subclasses of the linkage class implement it properly. Since CHelperLinkage is only used for call-outs to CHelper APIs we cannot implement this function properly, nor do we need to since no one should ever be calling it. We add a fatal assert to ensure this is the case. Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
fjeremic
force-pushed
the
jitbuilder-call
branch
from
19d48cf
to
a5b72fd
Compare
|
Jenkins test sanity all jdk8 depends eclipse/omr#4776 |
fjeremic
changed the title
|
Unmarking WIP. @pshipton this one is ready if you would like to be a committer for it. |
pshipton
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pure virtual function as introduced in OMR to ensure all
subclasses of the linkage class implement it properly. Since
CHelperLinkage is only used for call-outs to CHelper APIs we cannot
implement this function properly, nor do we need to since no one should
ever be calling it. We add a fatal assert to ensure this is the case.
Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com